Skip to content

Fix GraphQL operation type header#2956

Merged
jonathanmos merged 1 commit into
developfrom
jmoskovich/fix-graphql-operation-type
Oct 21, 2025
Merged

Fix GraphQL operation type header#2956
jonathanmos merged 1 commit into
developfrom
jmoskovich/fix-graphql-operation-type

Conversation

@jonathanmos

@jonathanmos jonathanmos commented Oct 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

The header had an underscore instead of a hyphen. It's internal and shared between DatadogApolloInterceptor and DatadogInterceptor, so there should be no impact in fixing this (other than code correctness).

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 21, 2025 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 70.92% (+0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e880002 | Docs | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Oct 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.85%. Comparing base (365637f) to head (e880002).
⚠️ Report is 1323 commits behind head on develop.

Files with missing lines Patch % Lines
...datadog/android/internal/network/GraphQLHeaders.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2956      +/-   ##
===========================================
- Coverage    70.85%   70.85%   -0.01%     
===========================================
  Files          829      829              
  Lines        30384    30384              
  Branches      5184     5184              
===========================================
- Hits         21528    21526       -2     
- Misses        7379     7381       +2     
  Partials      1477     1477
Files with missing lines Coverage Δ
...datadog/android/internal/network/GraphQLHeaders.kt 0.00% <0.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonathanmos
jonathanmos marked this pull request as ready for review October 21, 2025 10:56
@jonathanmos
jonathanmos requested review from a team as code owners October 21, 2025 10:56
@jonathanmos
jonathanmos merged commit d493283 into develop Oct 21, 2025
26 checks passed
@jonathanmos
jonathanmos deleted the jmoskovich/fix-graphql-operation-type branch October 21, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonathanmos @codecov-commenter @0xnm @aleksandr-gringauz