RUM-11785: Do not create a new session for TTID#2954
Merged
aleksandr-gringauz merged 1 commit intoOct 21, 2025
Merged
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: fc9e589 | Docs | Was this helpful? Give us feedback! |
aleksandr-gringauz
marked this pull request as ready for review
October 20, 2025 13:10
0xnm
approved these changes
Oct 20, 2025
ambushwork
approved these changes
Oct 20, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2954 +/- ##
===========================================
- Coverage 70.90% 70.81% -0.08%
===========================================
Files 829 829
Lines 30385 30384 -1
Branches 5184 5184
===========================================
- Hits 21542 21516 -26
- Misses 7370 7390 +20
- Partials 1473 1478 +5
🚀 New features to boost your workflow:
|
jonathanmos
approved these changes
Oct 20, 2025
aleksandr-gringauz
deleted the
aleksandr-gringauz/RUM-11785/do-not-create-new-session
branch
October 21, 2025 08:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is related to this discussion. I thought about it a bit more and think that TTID event shouldn't trigger session recreation.
Reasons:
StartViewaction (considered interaction) the session wasn't started. The TTID event that happens a bit later gives another chance to start the session. By giving more chances to start the session we effectively increase the sampling rate.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)