Skip to content

[flags] FFL-1237: Add telemetry for critical paths#2952

Merged
jonathanmos merged 1 commit into
feature/feature-flaggingfrom
jmoskovich/ffl-1237/critical-telemetry
Oct 21, 2025
Merged

[flags] FFL-1237: Add telemetry for critical paths#2952
jonathanmos merged 1 commit into
feature/feature-flaggingfrom
jmoskovich/ffl-1237/critical-telemetry

Conversation

@jonathanmos

@jonathanmos jonathanmos commented Oct 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Add telemetry for errors when downloading precomputed flags and parsing them, and for errors reading precomputed flag data from the datastore.

Motivation

Cover critical paths with telemetry.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos
jonathanmos force-pushed the jmoskovich/ffl-1237/critical-telemetry branch from a05e997 to 0e3f673 Compare October 20, 2025 11:08
@codecov-commenter

codecov-commenter commented Oct 20, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.86%. Comparing base (a70a89e) to head (0e3f673).
⚠️ Report is 7 commits behind head on feature/feature-flagging.

Files with missing lines Patch % Lines
...ternal/net/PrecomputedAssignmentsRequestFactory.kt 0.00% 1 Missing and 1 partial ⚠️
...eflags/internal/repository/net/PrecomputeMapper.kt 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##           feature/feature-flagging    #2952      +/-   ##
============================================================
+ Coverage                     70.76%   70.86%   +0.10%     
============================================================
  Files                           835      837       +2     
  Lines                         30388    30434      +46     
  Branches                       5132     5136       +4     
============================================================
+ Hits                          21504    21566      +62     
+ Misses                         7431     7425       -6     
+ Partials                       1453     1443      -10
Files with missing lines Coverage Δ
.../flags/featureflags/internal/DatadogFlagsClient.kt 96.15% <100.00%> (+9.31%) ⬆️
...ags/internal/persistence/FlagsStateDeserializer.kt 98.41% <100.00%> (+14.20%) ⬆️
...roid/flags/internal/net/ExposuresRequestFactory.kt 100.00% <100.00%> (ø)
...s/internal/net/PrecomputedAssignmentsDownloader.kt 100.00% <100.00%> (+36.84%) ⬆️
...eflags/internal/repository/net/PrecomputeMapper.kt 97.44% <83.33%> (-2.56%) ⬇️
...ternal/net/PrecomputedAssignmentsRequestFactory.kt 69.81% <0.00%> (-3.27%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonathanmos
jonathanmos marked this pull request as ready for review October 20, 2025 12:56
@jonathanmos
jonathanmos requested review from a team as code owners October 20, 2025 12:56
@jonathanmos
jonathanmos requested a review from typotter October 20, 2025 14:17
@jonathanmos
jonathanmos merged commit 969ad5d into feature/feature-flagging Oct 21, 2025
25 checks passed
@jonathanmos
jonathanmos deleted the jmoskovich/ffl-1237/critical-telemetry branch October 21, 2025 07:11
This was referenced Nov 4, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@typotter typotter typotter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonathanmos @codecov-commenter @0xnm @typotter