RUM-11990: Defer requestProfiling to next app launch by ambushwork · Pull Request #2950 · DataDog/dd-sdk-android

ambushwork · 2025-10-17T15:38:48Z

What does this PR do?

This PR enables the profiling request as early as possible during the app launch:

Add DdProfilingContentProvider to start the profiling request.
Add ProfilingStorage to read/save/clean the profiling flag to defer the profiling request to the next app launch.

Motivation

RUM-11990

Additional Notes

Profiling Sampling rate is not covered by this PR.

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

datadog-datadog-prod-us1 · 2025-10-20T14:03:13Z

🎯 Code Coverage
• Patch Coverage: 56.72%
• Total Coverage: 70.94% (+0.01%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: c4f87a2 | Docs | Was this helpful? Give us feedback!}

codecov-commenter · 2025-10-21T08:10:12Z

Codecov Report

❌ Patch coverage is 48.27586% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.90%. Comparing base (4895fe1) to head (c4f87a2).
⚠️ Report is 920 commits behind head on feature/perfetto-profiling.

Files with missing lines	Patch %	Lines
...og/android/profiling/DdProfilingContentProvider.kt	0.00%	16 Missing ⚠️
...in/java/com/datadog/android/profiling/Profiling.kt	0.00%	8 Missing ⚠️
...atadog/android/internal/data/PreferencesStorage.kt	0.00%	3 Missing ⚠️
...id/profiling/internal/perfetto/PerfettoProfiler.kt	50.00%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@                      Coverage Diff                       @@
##           feature/perfetto-profiling    #2950      +/-   ##
==============================================================
+ Coverage                       70.89%   70.90%   +0.01%     
==============================================================
  Files                             839      842       +3     
  Lines                           30579    30616      +37     
  Branches                         5192     5204      +12     
==============================================================
+ Hits                            21676    21706      +30     
- Misses                           7428     7430       +2     
- Partials                         1475     1480       +5

Files with missing lines	Coverage Δ
.../android/internal/data/SharedPreferencesStorage.kt	`100.00% <100.00%> (ø)`
...dog/android/profiling/internal/ProfilingFeature.kt	`86.67% <100.00%> (-1.57%)`	⬇️
...dog/android/profiling/internal/ProfilingStorage.kt	`100.00% <100.00%> (ø)`
...atadog/android/internal/data/PreferencesStorage.kt	`0.00% <0.00%> (ø)`
...id/profiling/internal/perfetto/PerfettoProfiler.kt	`90.74% <50.00%> (-5.49%)`	⬇️
...in/java/com/datadog/android/profiling/Profiling.kt	`0.00% <0.00%> (ø)`
...og/android/profiling/DdProfilingContentProvider.kt	`0.00% <0.00%> (ø)`

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aleksandr-gringauz · 2025-10-21T14:48:19Z

+    }
+
+    companion object {
+        internal const val DATADOG_PREFERENCES_FILE_NAME = "dd_prefs"


Just a heads up.

There is this comment in the RFC about the case when we have multiple instances of the SDK in the app.

Currently they will use the same shared preferences which is probably not good. We might need to parametrize this with sdkInstanceName string.

Not a blocking comment for this PR. Maybe you'll come up with better ideas.

+1 on this: what we are missing is multiple SDK cores support.

To start recording we need that any of the cores requested it (at least with current configuration where sampling rate is hardcoded), so this is probably fine for the flag to be shared, but we need to:

make sure that after recording is done it is sent to the proper core which requested it.

make sure that we don't run several profiles in parallel.

I agree, I think the multiple SDK core issue is not mainly on SharedPreference flag, but on the ProfilingFeature implementation about writing and uploading events as you said. For the dogfooding it's not an issue, I create a ticket to handle it in as a separate task

0xnm

I think what we are missing is multiple SDK cores support, we need to refine this flow.

0xnm · 2025-10-21T15:23:29Z

+ * An implementation of [PreferencesStorage] that uses Android's [SharedPreferences] as storage
+ * backend.
+ */
+class SharedPreferencesStorage(context: Context) : PreferencesStorage {


public class is exposing internal interface, there should be warning about this. We need to make interface public as well then.

0xnm · 2025-10-21T15:23:55Z

+ * An implementation of [PreferencesStorage] that uses Android's [SharedPreferences] as storage
+ * backend.
+ */
+class SharedPreferencesStorage(context: Context) : PreferencesStorage {


minor: let's make it clear what we expect application context here

Suggested change

class SharedPreferencesStorage(context: Context) : PreferencesStorage {

class SharedPreferencesStorage(appContext: Context) : PreferencesStorage {

0xnm · 2025-10-21T15:26:22Z

+    }
+
+    companion object {
+        internal const val DATADOG_PREFERENCES_FILE_NAME = "dd_prefs"


+1 on this: what we are missing is multiple SDK cores support.

To start recording we need that any of the cores requested it (at least with current configuration where sampling rate is hardcoded), so this is probably fine for the flag to be shared, but we need to:

make sure that after recording is done it is sent to the proper core which requested it.

make sure that we don't run several profiles in parallel.

0xnm · 2025-10-22T12:50:11Z

+ * An implementation of [PreferencesStorage] that uses Android's [SharedPreferences] as storage
+ * backend.
+ */
+class SharedPreferencesStorage(appContext: Context) : PreferencesStorage {


one downside is that we will trigger Strict Mode violation, because we need to read from disk on I/O thread, but I guess we don't have any other choice.

0xnm · 2025-10-22T12:51:19Z

+    /**
+     * Put a string value in the storage.
+     */
+    fun getString(key: String): String?


we are not supplying any default value here as we do with getInt and getBoolean methods?

0xnm · 2025-10-22T12:59:08Z

+private const val KEY_PROFILING_ENABLED = "dd_profiling_enabled"
+
+internal fun setProfilingFlag(appContext: Context) {
+    SharedPreferencesStorage(appContext).putBoolean(KEY_PROFILING_ENABLED, true)


minor: each instance creation will involve doing appContext.getSharedPreferences call, which is probably doing I/O, so ideally we could create an instance only once if it is a concern

Update ProfilingStage to singleton with unit test

0xnm · 2025-10-23T08:27:48Z

+        // Reset the singleton
+        val storageField = ProfilingStorage::class.java.getDeclaredField("sharedPreferencesStorage")
+        storageField.isAccessible = true
+        storageField.set(ProfilingStorage, null)


minor: probably it is better to do it in the AfterEach (or maybe even in both BeforeEach and AfterEach), because we will leave the object with state set and this object may be used in another test class.

0xnm · 2025-10-23T08:28:42Z

+        val isEnabled = ProfilingStorage.isProfilingEnabled(mockContext)
+
+        // Then
+        Assertions.assertThat(isEnabled).isTrue()


nit: can be a static import

0xnm · 2025-10-23T08:28:51Z

+        latch.await(5, TimeUnit.SECONDS)
+
+        // Then
+        verify(mockContext, times(1)).getSharedPreferences(


Suggested change

verify(mockContext, times(1)).getSharedPreferences(

verify(mockContext).getSharedPreferences(

ambushwork force-pushed the yl/profiling/defer-profiling branch 6 times, most recently from 6fe7292 to 1846513 Compare October 20, 2025 13:33

ambushwork force-pushed the yl/profiling/defer-profiling branch from 1846513 to d595d0e Compare October 21, 2025 07:31

ambushwork marked this pull request as ready for review October 21, 2025 08:04

ambushwork requested review from a team as code owners October 21, 2025 08:04

aleksandr-gringauz reviewed Oct 21, 2025

View reviewed changes

Comment thread features/dd-sdk-android-profiling/src/main/AndroidManifest.xml Outdated

ambushwork force-pushed the yl/profiling/defer-profiling branch from d595d0e to da6a14c Compare October 21, 2025 12:11

aleksandr-gringauz previously approved these changes Oct 21, 2025

View reviewed changes

aleksandr-gringauz reviewed Oct 21, 2025

View reviewed changes

0xnm requested changes Oct 21, 2025

View reviewed changes

ambushwork dismissed aleksandr-gringauz’s stale review via 1e3aa9d October 22, 2025 07:58

ambushwork force-pushed the yl/profiling/defer-profiling branch 3 times, most recently from e8d21b1 to 7dbecec Compare October 22, 2025 08:13

ambushwork requested review from 0xnm and aleksandr-gringauz October 22, 2025 09:05

ambushwork force-pushed the yl/profiling/defer-profiling branch 2 times, most recently from 9774f31 to 5509e32 Compare October 22, 2025 11:51

aleksandr-gringauz previously approved these changes Oct 22, 2025

View reviewed changes

0xnm previously approved these changes Oct 22, 2025

View reviewed changes

RUM-11990: Defer requestProfiling to next app launch

c4f87a2

ambushwork dismissed stale reviews from 0xnm and aleksandr-gringauz via c4f87a2 October 22, 2025 14:46

ambushwork force-pushed the yl/profiling/defer-profiling branch from 5509e32 to c4f87a2 Compare October 22, 2025 14:46

ambushwork requested review from 0xnm and aleksandr-gringauz October 22, 2025 15:27

aleksandr-gringauz approved these changes Oct 22, 2025

View reviewed changes

0xnm approved these changes Oct 23, 2025

View reviewed changes

ambushwork merged commit 46d5192 into feature/perfetto-profiling Oct 23, 2025
25 of 26 checks passed

ambushwork deleted the yl/profiling/defer-profiling branch October 23, 2025 08:32

	class SharedPreferencesStorage(context: Context) : PreferencesStorage {
	class SharedPreferencesStorage(appContext: Context) : PreferencesStorage {

	verify(mockContext, times(1)).getSharedPreferences(
	verify(mockContext).getSharedPreferences(

Uh oh!

Conversation

ambushwork commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

Uh oh!

datadog-datadog-prod-us1 Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

aleksandr-gringauz Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xnm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ambushwork commented Oct 17, 2025 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Oct 20, 2025 •

edited

Loading

codecov-commenter commented Oct 21, 2025 •

edited

Loading

aleksandr-gringauz Oct 21, 2025 •

edited

Loading