Use stub Executor for WorkerParameters forgery factory#2949
Merged
0xnm merged 1 commit intoOct 20, 2025
Conversation
0xnm
force-pushed
the
nogorodnikov/use-stub-executor-for-workerparameters-forgery
branch
from
October 17, 2025 15:12
dc5dfdd to
e8721de
Compare
ambushwork
approved these changes
Oct 17, 2025
aleksandr-gringauz
approved these changes
Oct 17, 2025
|
🎯 Code Coverage 🔗 Commit SHA: e8721de | Docs | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2949 +/- ##
===========================================
- Coverage 71.02% 70.81% -0.21%
===========================================
Files 829 829
Lines 30381 30381
Branches 5183 5183
===========================================
- Hits 21578 21514 -64
- Misses 7347 7392 +45
- Partials 1456 1475 +19 🚀 New features to boost your workflow:
|
jonathanmos
approved these changes
Oct 20, 2025
0xnm
deleted the
nogorodnikov/use-stub-executor-for-workerparameters-forgery
branch
October 20, 2025 07:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tiny improvement: avoid creating a real
Executorspinning a real thread in the forgery factory.Review checklist (to be filled by reviewers)