Skip to content

RUM-12060: Fix GitLab CI Pipeline#2948

Merged
kikoveiga merged 9 commits into
tvaleev/feature/innovation-week-07-04-25from
kikoveiga/RUM-12060/fix-widget-code
Oct 23, 2025
Merged

RUM-12060: Fix GitLab CI Pipeline#2948
kikoveiga merged 9 commits into
tvaleev/feature/innovation-week-07-04-25from
kikoveiga/RUM-12060/fix-widget-code

Conversation

@kikoveiga

@kikoveiga kikoveiga commented Oct 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR mainly fixes the warnings and errors caught by the GitLab CI pipeline.

Motivation

My first onboarding task is to improve and refactor the RUM Debug Widget code created by Timur Valeev (@satween) during the last Innovation Week.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-official

datadog-official Bot commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 30.56%
• Total Coverage: 70.17%

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c1068e2 | Docs | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 27.02703% with 27 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (tvaleev/feature/innovation-week-07-04-25@8490695). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../android/insights/internal/widgets/TimelineView.kt 0.00% 9 Missing ⚠️
...dog/android/insights/internal/widgets/ChartView.kt 0.00% 7 Missing ⚠️
...roid/insights/internal/DefaultInsightsCollector.kt 20.00% 4 Missing ⚠️
...om/datadog/android/insights/LocalInsightOverlay.kt 0.00% 3 Missing ⚠️
...og/android/insights/internal/extensions/LangExt.kt 0.00% 3 Missing ⚠️
...droid/insights/internal/extensions/AnimationExt.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                             Coverage Diff                             @@
##             tvaleev/feature/innovation-week-07-04-25    #2948   +/-   ##
===========================================================================
  Coverage                                            ?   70.27%           
===========================================================================
  Files                                               ?      838           
  Lines                                               ?    30771           
  Branches                                            ?     5231           
===========================================================================
  Hits                                                ?    21624           
  Misses                                              ?     7694           
  Partials                                            ?     1453
Files with missing lines Coverage Δ
...g/android/insights/internal/InsightStateStorage.kt 0.00% <ø> (ø)
.../android/insights/internal/domain/TimelineEvent.kt 0.00% <ø> (ø)
...oid/insights/internal/widgets/DragTouchListener.kt 0.00% <ø> (ø)
...kotlin/com/datadog/android/rum/RumConfiguration.kt 95.12% <ø> (ø)
...droid/rum/configuration/SlowFramesConfiguration.kt 100.00% <100.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 90.58% <100.00%> (ø)
...ndroid/rum/internal/domain/scope/RumActionScope.kt 97.06% <100.00%> (ø)
...d/rum/internal/domain/scope/RumApplicationScope.kt 95.24% <100.00%> (ø)
...droid/rum/internal/domain/scope/RumSessionScope.kt 94.93% <ø> (ø)
...d/rum/internal/domain/scope/RumViewManagerScope.kt 93.55% <100.00%> (ø)
... and 8 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween

satween commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

It's important to fill the description template to help reviewers get more context of a changes.

satween
satween reviewed Oct 20, 2025
View reviewed changes
Comment thread ...android-rum/src/main/kotlin/com/datadog/android/insights/internal/extensions/AnimationExt.kt Outdated
Comment thread ...-sdk-android-rum/src/main/kotlin/com/datadog/android/insights/internal/extensions/LangExt.kt
Comment thread ...d-sdk-android-rum/src/main/kotlin/com/datadog/android/insights/internal/widgets/ChartView.kt Outdated
Comment thread ...d-sdk-android-rum/src/main/kotlin/com/datadog/android/insights/internal/widgets/ChartView.kt Outdated
Comment thread ...sdk-android-rum/src/main/kotlin/com/datadog/android/insights/internal/InsightStateStorage.kt Outdated
Comment thread ...sdk-android-rum/src/main/kotlin/com/datadog/android/insights/internal/InsightStateStorage.kt Outdated
Comment thread .../dd-sdk-android-rum/src/main/kotlin/com/datadog/android/insights/DefaultInsightsCollector.kt Outdated
Comment thread features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/insights/LocalInsightOverlay.kt Outdated
Comment thread ...c/main/kotlin/com/datadog/android/rum/internal/instrumentation/insights/InsightsCollector.kt Outdated
Comment thread features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/RumFeature.kt Outdated
@kikoveiga
kikoveiga marked this pull request as ready for review October 20, 2025 15:51
@kikoveiga
kikoveiga requested review from a team as code owners October 20, 2025 15:51
@kikoveiga
kikoveiga requested a review from satween October 20, 2025 15:51
@kikoveiga kikoveiga changed the title RUM-12060: Fixed local ci unit tests and detekt static analysis RUM-12060: Fix GitLab CI Pipeline Oct 20, 2025
@kikoveiga
kikoveiga merged commit 44ff748 into tvaleev/feature/innovation-week-07-04-25 Oct 23, 2025
25 of 26 checks passed
@kikoveiga
kikoveiga deleted the kikoveiga/RUM-12060/fix-widget-code branch October 23, 2025 12:57
@ncreated
ncreated restored the kikoveiga/RUM-12060/fix-widget-code branch April 9, 2026 10:20
@0xnm
0xnm deleted the kikoveiga/RUM-12060/fix-widget-code branch April 24, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@satween satween satween approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kikoveiga @codecov-commenter @satween