RUM-12059: RUM Debug Widget#2943
Conversation
…novation-week-07-04-25 # Conflicts: # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/Rum.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/RumFeature.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumActionScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumApplicationScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumSessionScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewManagerScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewScope.kt # features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/monitor/DatadogRumMonitor.kt
… documentation missing
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 665ca85ae1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0dbad53 to
b86c26e
Compare
aleksandr-gringauz
left a comment
aleksandr-gringauz
left a comment
There was a problem hiding this comment.
Code-wise LGTM.
I remember there was a discussion about merging this widget with RumMonitor.debug somehow.
Are you planning to release the widget the way it is now in the PR?
| } | ||
|
|
||
| private fun registerEvent(event: TimelineEvent) = withListenersUpdate { | ||
| events += event |
There was a problem hiding this comment.
Actually... I looked once more into this version of the code. I missed that withListenersUpdate is actually executing the block of code inside handler.post, so probably it was fine and no extra lock is needed here.
Sorry, my mistake.
Yes, as discussed with @satween we will keep both. |
…umApi annotation.
…novation-week-07-04-25
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
This pull request was merged directly. |
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
6 participants
What does this PR do?
Adds a new feature RUM Debug Widget, which displays RUM data in real time. It lives inside its own module
features/dd-sdk-android-rum-debug-widget.Motivation
It is useful for customers to understand if our SDK is correctly configured inside their apps and if RUM events are being collected.
Review checklist (to be filled by reviewers)