RUM-12063: Support long task reporting for multiple SDK instances#2934
Merged
0xnm merged 1 commit intoOct 13, 2025
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-12063/support-long-task-reporting-for-multiple-sdk-instances
branch
from
October 13, 2025 12:44
f325262 to
2835599
Compare
|
🎯 Code Coverage 🔗 Commit SHA: d6ac62e | Docs | Was this helpful? Give us feedback! |
aleksandr-gringauz
previously approved these changes
Oct 13, 2025
0xnm
force-pushed
the
nogorodnikov/rum-12063/support-long-task-reporting-for-multiple-sdk-instances
branch
from
October 13, 2025 13:11
2835599 to
d6ac62e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2934 +/- ##
===========================================
+ Coverage 70.72% 70.80% +0.08%
===========================================
Files 829 829
Lines 30379 30384 +5
Branches 5182 5183 +1
===========================================
+ Hits 21483 21512 +29
+ Misses 7421 7395 -26
- Partials 1475 1477 +2
🚀 New features to boost your workflow:
|
ambushwork
approved these changes
Oct 13, 2025
0xnm
deleted the
nogorodnikov/rum-12063/support-long-task-reporting-for-multiple-sdk-instances
branch
October 13, 2025 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This issue was reported at #2919 (comment).
We fail to report long tasks for multiple SDK instances, because the way it is reported is utilizing setMessageLogging which supports only one
Printerinstance. So the last SDK instance initialized will get these reports, but SDK instances created before won't.This PR fixes it by adding a composite printer which will dispatch log messages to the printers registered.
Review checklist (to be filled by reviewers)