Skip to content

RUM-11887: Send TTID event to Profiling feature to stop profiling#2933

Merged
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling/add-sample
Oct 14, 2025
Merged

RUM-11887: Send TTID event to Profiling feature to stop profiling#2933
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling/add-sample

Conversation

@ambushwork

@ambushwork ambushwork commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

  • Send TTID event from RUM feature when TTID is detected.
  • Receive TTID event and stop perfetto profiling.
  • Some internal moves of files between the packages.
  • Enable profiling feature in Sample app

Motivation

RUM-11887

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 13, 2025 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 44.83%
• Total Coverage: 70.88% (+0.04%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6769649 | Docs | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 46.15385% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.78%. Comparing base (fe77c2f) to head (6769649).
⚠️ Report is 944 commits behind head on feature/perfetto-profiling.

Files with missing lines Patch % Lines
...ling/internal/perfetto/PerfettoProfilerProvider.kt 0.00% 6 Missing ⚠️
...lin/com/datadog/android/rum/internal/RumFeature.kt 0.00% 3 Missing ⚠️
...in/java/com/datadog/android/profiling/Profiling.kt 0.00% 2 Missing ⚠️
...dog/android/profiling/internal/ProfilingFeature.kt 85.71% 2 Missing ⚠️
...src/main/java/com/datadog/android/rum/TTIDEvent.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                      Coverage Diff                       @@
##           feature/perfetto-profiling    #2933      +/-   ##
==============================================================
- Coverage                       70.85%   70.78%   -0.07%     
==============================================================
  Files                             837      839       +2     
  Lines                           30479    30501      +22     
  Branches                         5183     5185       +2     
==============================================================
- Hits                            21594    21588       -6     
- Misses                           7418     7430      +12     
- Partials                         1467     1483      +16
Files with missing lines Coverage Δ
.../android/profiling/internal/ProfilingDataWriter.kt 97.14% <ø> (ø)
...id/profiling/internal/perfetto/PerfettoProfiler.kt 96.23% <ø> (ø)
...roid/profiling/internal/perfetto/PerfettoResult.kt 100.00% <ø> (ø)
...src/main/java/com/datadog/android/rum/TTIDEvent.kt 0.00% <0.00%> (ø)
...in/java/com/datadog/android/profiling/Profiling.kt 0.00% <0.00%> (ø)
...dog/android/profiling/internal/ProfilingFeature.kt 88.24% <85.71%> (+1.28%) ⬆️
...lin/com/datadog/android/rum/internal/RumFeature.kt 89.02% <0.00%> (-0.90%) ⬇️
...ling/internal/perfetto/PerfettoProfilerProvider.kt 0.00% <0.00%> (ø)

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork force-pushed the yl/profiling/add-sample branch from b999d76 to 37c6e9b Compare October 13, 2025 15:25
@ambushwork
ambushwork marked this pull request as ready for review October 13, 2025 15:39
@ambushwork
ambushwork requested review from a team as code owners October 13, 2025 15:39
0xnm
0xnm previously approved these changes Oct 13, 2025
View reviewed changes
Comment thread ...k-android-profiling/src/main/java/com/datadog/android/profiling/internal/ProfilerProvider.kt Outdated
Comment thread ...k-android-profiling/src/main/java/com/datadog/android/profiling/internal/ProfilingFeature.kt Outdated
Comment thread ...ng/src/main/java/com/datadog/android/profiling/internal/perfetto/PerfettoProfilerProvider.kt
@ambushwork
ambushwork dismissed stale reviews from aleksandr-gringauz and 0xnm via bb90768 October 14, 2025 06:19
@ambushwork
ambushwork force-pushed the yl/profiling/add-sample branch from 37c6e9b to bb90768 Compare October 14, 2025 06:19
@ambushwork
ambushwork force-pushed the yl/profiling/add-sample branch from bb90768 to 6769649 Compare October 14, 2025 06:52
@ambushwork
ambushwork merged commit 542c6a6 into feature/perfetto-profiling Oct 14, 2025
25 of 27 checks passed
@ambushwork
ambushwork deleted the yl/profiling/add-sample branch October 14, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @0xnm @aleksandr-gringauz