Skip to content

[RUM-12047][FO]: fix missed tags#2928

Merged
satween merged 3 commits into
developfrom
tvaleev/feature/RUM-12047-fix-missed-tags
Oct 10, 2025
Merged

[RUM-12047][FO]: fix missed tags#2928
satween merged 3 commits into
developfrom
tvaleev/feature/RUM-12047-fix-missed-tags

Conversation

@satween

@satween satween commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes issue with missing attributes for vital event

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween requested review from a team as code owners October 9, 2025 16:19
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 9, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 93.42%
Total Coverage: 70.74% (+0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: add9978 | Docs | Was this helpful? Give us feedback!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.84211% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.77%. Comparing base (fd31d41) to head (add9978).
⚠️ Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...g/android/rum/internal/domain/scope/RumEventExt.kt 81.08% 5 Missing and 2 partials ⚠️
.../android/rum/internal/domain/scope/RumViewScope.kt 92.31% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2928      +/-   ##
===========================================
- Coverage    70.84%   70.77%   -0.07%     
===========================================
  Files          825      825              
  Lines        30284    30360      +76     
  Branches      5174     5180       +6     
===========================================
+ Hits         21452    21486      +34     
- Misses        7366     7403      +37     
- Partials      1466     1471       +5     
Files with missing lines Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 93.70% <92.31%> (-0.36%) ⬇️
...g/android/rum/internal/domain/scope/RumEventExt.kt 92.66% <81.08%> (-2.30%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween
satween merged commit c209a89 into develop Oct 10, 2025
26 checks passed
@satween
satween deleted the tvaleev/feature/RUM-12047-fix-missed-tags branch October 10, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants