Skip to content

Umbrella PR for TTID telemetry reporting#2921

Merged
aleksandr-gringauz merged 12 commits into
developfrom
aleksandr-gringauz/feature/app-launch-prs
Oct 8, 2025
Merged

Umbrella PR for TTID telemetry reporting#2921
aleksandr-gringauz merged 12 commits into
developfrom
aleksandr-gringauz/feature/app-launch-prs

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR contains changes from the following already reviewed PRs and nothing more:

#2861
#2882
#2883
#2908
#2910
#2920

It implements detecting app startup type, computing TTID and reporting it to Telemetry. Currently there is no upload of data to the customers' orgs, they won't see anything. We still need frontend development before we can do it.

I want to merge this code to develop for the following reasons:

  1. Start looking at the telemetry for our internal apps.
  2. When this code goes to production in the next release we can start looking at telemetry on real-world data.
  3. Our work on profiling depends on the work for detecting app launch, so it will be convenient to have it in develop.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 93.13%
• Total Coverage: 70.82% (+0.24%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7f05efa | Docs | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.72581% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.78%. Comparing base (7fa9000) to head (7f05efa).
⚠️ Report is 1383 commits behind head on develop.

Files with missing lines Patch % Lines
...lin/com/datadog/android/rum/internal/RumFeature.kt 38.89% 10 Missing and 1 partial ⚠️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 40.00% 3 Missing ⚠️
...m/internal/startup/RumFirstDrawTimeReporterImpl.kt 94.44% 2 Missing and 1 partial ⚠️
...droid/rum/internal/domain/scope/RumSessionScope.kt 85.71% 0 Missing and 2 partials ⚠️
.../rum/internal/startup/RumAppStartupDetectorImpl.kt 95.74% 0 Missing and 2 partials ⚠️
...nternal/utils/window/RumWindowCallbacksRegistry.kt 92.31% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2921      +/-   ##
===========================================
+ Coverage    70.70%   70.78%   +0.07%     
===========================================
  Files          815      825      +10     
  Lines        30053    30284     +231     
  Branches      5145     5174      +29     
===========================================
+ Hits         21248    21434     +186     
- Misses        7351     7385      +34     
- Partials      1454     1465      +11
Files with missing lines Coverage Δ
...n/com/datadog/android/core/internal/DatadogCore.kt 78.11% <ø> (-0.07%) ⬇️
.../core/internal/time/DefaultAppStartTimeProvider.kt 100.00% <100.00%> (ø)
...tadog/android/internal/utils/DDCoreSubscription.kt 100.00% <100.00%> (ø)
...va/com/datadog/android/rum/DdRumContentProvider.kt 87.50% <100.00%> (ø)
...rum/src/main/kotlin/com/datadog/android/rum/Rum.kt 89.06% <100.00%> (+0.17%) ⬆️
...adog/android/rum/internal/FixedWindowCallback.java 88.89% <100.00%> (ø)
...d/rum/internal/domain/scope/RumApplicationScope.kt 95.12% <100.00%> (+0.12%) ⬆️
...g/android/rum/internal/domain/scope/RumRawEvent.kt 99.43% <100.00%> (+0.01%) ⬆️
.../instrumentation/gestures/WindowCallbackWrapper.kt 84.34% <ø> (ø)
...roid/rum/internal/startup/RumAppStartupDetector.kt 100.00% <100.00%> (ø)
... and 11 more

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz
aleksandr-gringauz marked this pull request as ready for review October 8, 2025 14:19
@aleksandr-gringauz
aleksandr-gringauz requested review from a team as code owners October 8, 2025 14:19
@aleksandr-gringauz
aleksandr-gringauz merged commit fd31d41 into develop Oct 8, 2025
25 of 26 checks passed
@aleksandr-gringauz
aleksandr-gringauz deleted the aleksandr-gringauz/feature/app-launch-prs branch October 8, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@ambushwork ambushwork ambushwork approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aleksandr-gringauz @codecov-commenter @0xnm @ambushwork