RUM-11968: Implement Profiling Feature#2918
Conversation
b02476a to
1c50c7f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/perfetto-profiling #2918 +/- ##
==============================================================
- Coverage 70.79% 70.78% -0.01%
==============================================================
Files 821 823 +2
Lines 30152 30189 +37
Branches 5143 5143
==============================================================
+ Hits 21344 21367 +23
- Misses 7349 7362 +13
- Partials 1459 1460 +1
🚀 New features to boost your workflow:
|
| * will be used. | ||
| */ | ||
| @JvmStatic | ||
| @RequiresApi(Build.VERSION_CODES.VANILLA_ICE_CREAM) |
There was a problem hiding this comment.
do you think we should simply set minSdk to that for this module?
There was a problem hiding this comment.
I don't think so, it will force clients to upgrade their application's minSdk for using profiling feature. But actually we expect that anyone can import profiling feature, and they are able to enable it only for end user's device above SDK 35
There was a problem hiding this comment.
Good question.
If you try (change minSdk of a module to 30 and compile the sample), you have something like this:
Manifest merger failed : uses-sdk:minSdkVersion 23 cannot be smaller than version 30 declared in library [:integrations:dd-sdk-android-sqldelight] /Users/aleksandr.gringauz/projects/dd-sdk-android/integrations/dd-sdk-android-sqldelight/build/intermediates/merged_manifest/debug/processDebugManifest/AndroidManifest.xml as the library might be using APIs not available in 23
Suggestion: use a compatible library with a minSdk of at most 23,
or increase this project's minSdk version to at least 30,
or use tools:overrideLibrary="com.datadog.android.sqldelight" to force usage (may lead to runtime failures)
I'm almost sure it will be the same for the library when it isn't compiled, but downloaded. Because it is manifest merging.
The customer will have to use flavors (like this) to use the profiling module.
But the question is - how to deal with these flavors when uploading to google play. I currently don't know, research needed.
There was a problem hiding this comment.
This is important point indeed, thanks for bringing it.
There was a problem hiding this comment.
What's the thing to do here? do we want to bump the minSdk for this?
1c50c7f to
03cee8e
Compare
897b5fd to
a67463c
Compare
a67463c to
eed2352
Compare
What does this PR do?
ProfilingFeatureenableAPI inProfilingobjectProfilingConfigurationMotivation
RUM-11968
Review checklist (to be filled by reviewers)