Skip to content

RUM-11853: Implement Profiling writer and request factory#2915

Merged
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling/create-writer-uploader
Oct 7, 2025
Merged

RUM-11853: Implement Profiling writer and request factory#2915
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling/create-writer-uploader

Conversation

@ambushwork

@ambushwork ambushwork commented Oct 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This PR implements the logic how Perfetto Result should be written into batch file and how the profile request should be built.

Motivation

RUM-11853

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/profiling/create-writer-uploader branch 5 times, most recently from 5d16227 to 90db9b8 Compare October 6, 2025 14:37
@ambushwork
ambushwork marked this pull request as ready for review October 6, 2025 14:37
@ambushwork
ambushwork requested review from a team as code owners October 6, 2025 14:37
0xnm
0xnm requested changes Oct 6, 2025
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed production files so far

Comment thread dd-sdk-android-internal/src/main/java/com/datadog/android/internal/utils/TimeExt.kt Outdated
Comment thread ...ndroid-profiling/src/main/java/com/datadog/android/profiling/internal/ProfilingDataWriter.kt Outdated
Comment thread ...ndroid-profiling/src/main/java/com/datadog/android/profiling/internal/ProfilingDataWriter.kt Outdated
Comment thread ...ndroid-profiling/src/main/java/com/datadog/android/profiling/internal/ProfilingDataWriter.kt Outdated
Comment thread ...ndroid-profiling/src/main/java/com/datadog/android/profiling/internal/ProfilingDataWriter.kt
@ambushwork
ambushwork force-pushed the yl/profiling/create-writer-uploader branch 4 times, most recently from 34ea753 to e2ff654 Compare October 7, 2025 06:37
@codecov-commenter

codecov-commenter commented Oct 7, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.12346% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.74%. Comparing base (cf4f5fb) to head (b95d9b2).
⚠️ Report is 991 commits behind head on feature/perfetto-profiling.

Files with missing lines Patch % Lines
...roid/profiling/internal/ProfilingRequestFactory.kt 83.72% 7 Missing ⚠️
.../android/profiling/internal/ProfilingDataWriter.kt 97.14% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                      Coverage Diff                       @@
##           feature/perfetto-profiling    #2915      +/-   ##
==============================================================
- Coverage                       71.06%   70.74%   -0.32%     
==============================================================
  Files                             818      821       +3     
  Lines                           30071    30152      +81     
  Branches                         5025     5143     +118     
==============================================================
- Hits                            21369    21331      -38     
- Misses                           7327     7370      +43     
- Partials                         1375     1451      +76
Files with missing lines Coverage Δ
.../kotlin/com/datadog/android/api/feature/Feature.kt 100.00% <ø> (ø)
.../android/core/internal/persistence/file/FileExt.kt 83.33% <ø> (-1.67%) ⬇️
...java/com/datadog/android/internal/utils/TimeExt.kt 100.00% <100.00%> (ø)
.../android/profiling/internal/ProfilingDataWriter.kt 97.14% <97.14%> (ø)
...roid/profiling/internal/ProfilingRequestFactory.kt 83.72% <83.72%> (ø)

... and 87 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

0xnm
0xnm previously approved these changes Oct 7, 2025
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but nothing blocking.

Comment thread dd-sdk-android-internal/src/main/java/com/datadog/android/internal/utils/TimeExt.kt Outdated
Comment thread ...-profiling/src/test/kotlin/com/datadog/android/profiling/internal/ProfilingDataWriterTest.kt Outdated
Comment thread ...-profiling/src/test/kotlin/com/datadog/android/profiling/internal/ProfilingDataWriterTest.kt Outdated
Comment thread ...filing/src/test/kotlin/com/datadog/android/profiling/internal/ProfilingRequestFactoryTest.kt
Comment thread ...filing/src/test/kotlin/com/datadog/android/profiling/internal/ProfilingRequestFactoryTest.kt Outdated
@ambushwork
ambushwork dismissed stale reviews from 0xnm and aleksandr-gringauz via 1641843 October 7, 2025 08:23
@ambushwork
ambushwork force-pushed the yl/profiling/create-writer-uploader branch from e2ff654 to 1641843 Compare October 7, 2025 08:23
@ambushwork
ambushwork force-pushed the yl/profiling/create-writer-uploader branch from 1641843 to b95d9b2 Compare October 7, 2025 08:28
@ambushwork
ambushwork merged commit 2e8bbfc into feature/perfetto-profiling Oct 7, 2025
25 checks passed
@ambushwork
ambushwork deleted the yl/profiling/create-writer-uploader branch October 7, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @0xnm @aleksandr-gringauz