RUM-11948: Create Profiling Event schema#2912
Merged
Merged
Conversation
ambushwork
force-pushed
the
yl/profiling/create-event
branch
3 times, most recently
from
October 3, 2025 10:52
f49b410 to
2a9ee67
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/perfetto-profiling #2912 +/- ##
==============================================================
- Coverage 71.05% 71.02% -0.04%
==============================================================
Files 817 818 +1
Lines 30059 30071 +12
Branches 5024 5025 +1
==============================================================
- Hits 21357 21355 -2
- Misses 7327 7337 +10
- Partials 1375 1379 +4
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
October 3, 2025 11:38
0xnm
previously approved these changes
Oct 3, 2025
ambushwork
force-pushed
the
yl/profiling/create-event
branch
from
October 3, 2025 12:43
2a9ee67 to
d314d68
Compare
0xnm
approved these changes
Oct 3, 2025
|
|
||
| private var profilingStarted: AtomicBoolean = AtomicBoolean(false) | ||
|
|
||
| private var profilingStartTime = 0L |
Contributor
There was a problem hiding this comment.
I think it's better to make this profilingStartTime volatile. It is set in the calling thread of start method and read on profilingExecutor thread.
No need to update this pr, can be done later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ProfilingEventPerefettoResultto carry profiling result.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)