RUM-11785: Introduce telemetry for TTID#2910
Conversation
4a28844 to
35b10f0
Compare
| when (event) { | ||
| is RumRawEvent.AppStartTTIDEvent -> { | ||
| if (sessionState == State.TRACKED) { | ||
| rumAppStartupTelemetryReporter.reportTTID( |
There was a problem hiding this comment.
I expect that reporting the actual value to the RUM intake using Vitals will take place exactly next to this reportTTID call in RumSessionScope.
The new vital doesn't require a view, so no need to put this in RumViewScope.
It will be in the future PRs.
There was a problem hiding this comment.
I am not 100% sure about this, but as far as I know we bound every event to a view. I mean it's impossible to report an event without being bound to a view. Probably you should use background view or so? cc @0xnm
There was a problem hiding this comment.
We plan to actually not require view for TTID. Simao created a special type of vital for TTID and TTFD and made it so that it doesn't require view. However for now there is some frontend work that needs to be done so that this could be displayed properly.
DataDog/rum-events-format#302
DataDog/rum-events-format#306
That's why I said in the description that the code for sending the vitals will be in the future PRs. This PR only contains telemetry.
There was a problem hiding this comment.
I am not argue with that, but as TTID stands fro time to initial display maybe view still required to tell to the user which exact view is responsible for the initial display?
There was a problem hiding this comment.
I am not argue with that, but as TTID stands fro time to initial display maybe view still required to tell to the user which exact view is responsible for the initial display?
Currently we plan not to send the viewId with TTID vital. However the frontend implementation for this isn't ready and there is indeed a chance that we might encounter some unexpected problems and have to actually send the viewId. If so, ok - we will change our implementation.
We plan to show the TTID value only in session level UI, not on View level.
efa786f to
e5e9b38
Compare
| when (event) { | ||
| is RumRawEvent.AppStartTTIDEvent -> { | ||
| if (sessionState == State.TRACKED) { | ||
| rumAppStartupTelemetryReporter.reportTTID( |
There was a problem hiding this comment.
I am not 100% sure about this, but as far as I know we bound every event to a view. I mean it's impossible to report an event without being bound to a view. Probably you should use background view or so? cc @0xnm
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## aleksandr-gringauz/feature/app-launch-prs #2910 +/- ##
=============================================================================
+ Coverage 71.10% 71.14% +0.04%
=============================================================================
Files 819 822 +3
Lines 30058 30134 +76
Branches 5024 5036 +12
=============================================================================
+ Hits 21370 21437 +67
Misses 7300 7300
- Partials 1388 1397 +9
🚀 New features to boost your workflow:
|
e5e9b38 to
b6b5c16
Compare
d6f4c05 to
db229b3
Compare
db229b3 to
3f3bddd
Compare
5ad840f
into
aleksandr-gringauz/feature/app-launch-prs
4 participants
What does this PR do?
This pr connects together
RumAppStartupDetector,RumTTIDReporterand reports TTID value using telemetry along with some additional information. You can read the spec of the telemetry here.Reporting the values to RUM intake using Vitals will be done in future PRs, because currently there are some frontend problems that prevent them from being displayed properly.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)