Skip to content

Move TimeProvider into dd-sdk-android-internal#2906

Merged
ambushwork merged 1 commit into
developfrom
yl/move-time-provider-to-internal
Oct 1, 2025
Merged

Move TimeProvider into dd-sdk-android-internal#2906
ambushwork merged 1 commit into
developfrom
yl/move-time-provider-to-internal

Conversation

@ambushwork

@ambushwork ambushwork commented Sep 30, 2025

Copy link
Copy Markdown
Member

What does this PR do?

  • Move TimeProvider into dd-sdk-android-internal
  • Rename NoOpTimeProvider to DefaultTimeProvider because it's actually not a no-op implementation.
  • Remove TimeProvider in Session Replay module, replace them with the internal one.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/move-time-provider-to-internal branch from bf14729 to 9a8c157 Compare September 30, 2025 16:04
@ambushwork
ambushwork marked this pull request as ready for review September 30, 2025 16:06
@ambushwork
ambushwork requested review from a team as code owners September 30, 2025 16:06
@codecov-commenter

codecov-commenter commented Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.93%. Comparing base (fa39327) to head (9a8c157).
⚠️ Report is 464 commits behind head on develop.

Files with missing lines Patch % Lines
...tadog/android/internal/time/DefaultTimeProvider.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2906      +/-   ##
===========================================
- Coverage    71.07%   70.93%   -0.14%     
===========================================
  Files          815      815              
  Lines        30013    30013              
  Branches      5022     5022              
===========================================
- Hits         21330    21288      -42     
- Misses        7311     7333      +22     
- Partials      1372     1392      +20
Files with missing lines Coverage Δ
...n/com/datadog/android/core/internal/CoreFeature.kt 86.39% <100.00%> (ø)
...id/core/internal/metrics/BatchMetricsDispatcher.kt 95.95% <ø> (ø)
...g/android/core/internal/time/KronosTimeProvider.kt 100.00% <ø> (ø)
.../sessionreplay/internal/DefaultRecorderProvider.kt 94.33% <100.00%> (ø)
...replay/internal/processor/RumContextDataHandler.kt 100.00% <ø> (ø)
...nreplay/internal/recorder/SessionReplayRecorder.kt 95.28% <ø> (ø)
...lay/internal/recorder/WindowCallbackInterceptor.kt 100.00% <ø> (ø)
...ternal/recorder/callback/RecorderWindowCallback.kt 92.05% <ø> (ø)
...tadog/android/internal/time/DefaultTimeProvider.kt 0.00% <0.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork merged commit 6f16289 into develop Oct 1, 2025
25 checks passed
@ambushwork
ambushwork deleted the yl/move-time-provider-to-internal branch October 1, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes
@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ambushwork @codecov-commenter @0xnm @jonathanmos @aleksandr-gringauz