RUM-11831: Integrate Perfetto ProfilingManager API#2902
Merged
ambushwork merged 1 commit intoOct 1, 2025
Conversation
ambushwork
force-pushed
the
yl/profiling/add-perfetto-api
branch
11 times, most recently
from
September 30, 2025 11:42
dd8c48f to
cb42528
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/perfetto-profiling #2902 +/- ##
==============================================================
+ Coverage 70.93% 71.01% +0.07%
==============================================================
Files 816 817 +1
Lines 30014 30059 +45
Branches 5022 5024 +2
==============================================================
+ Hits 21290 21344 +54
+ Misses 7336 7335 -1
+ Partials 1388 1380 -8
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
September 30, 2025 12:39
0xnm
reviewed
Sep 30, 2025
| * Provides the current device timestamp. | ||
| * Meant for internal usage. | ||
| */ | ||
| interface TimeProvider { |
Member
There was a problem hiding this comment.
we already have com.datadog.android.core.internal.time.TimeProvider and also com.datadog.android.sessionreplay.internal.utils.TimeProvider.
Maybe it is worth to simply pull the one from core to internal? Otherwise we have 3 TimeProvider interfaces.
Member
Author
There was a problem hiding this comment.
Rebased the branch and replaced it with the new merged TimeProvider in internal
| private val timeProvider: TimeProvider | ||
| ) : Profiler { | ||
|
|
||
| private val profilingExecutor = Executors.newSingleThreadExecutor() |
Member
There was a problem hiding this comment.
is it worth to pull it to the constructor to be able to inject the "same-thread" executor for tests?
ambushwork
force-pushed
the
yl/profiling/add-perfetto-api
branch
3 times, most recently
from
October 1, 2025 09:45
725d436 to
40cd5ac
Compare
ambushwork
force-pushed
the
yl/profiling/add-perfetto-api
branch
from
October 1, 2025 10:00
40cd5ac to
b5724e3
Compare
aleksandr-gringauz
approved these changes
Oct 1, 2025
0xnm
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR creates
PerfettoProfilerto delegate PerfettoProfilingManagerAPI:startandstopto internal module to start and stop profilingMotivation
RUM-11831
Additional Notes
TimeProviderInterface and default implementation ininternalmodule since we need it inPerfettoProfilerandroidx.coreversion to 1.17.0 which deprecatesGestureDetectorCompatin RUMGesturesDetectorWrapper, but we Suppress it in this PR.Review checklist (to be filled by reviewers)