Fix detekt issues [WIP]#2885
Merged
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/fix-flags-ci
branch
from
September 17, 2025 19:55
3efa713 to
3caae1e
Compare
jonathanmos
force-pushed
the
jmoskovich/fix-flags-ci
branch
from
September 17, 2025 20:05
3caae1e to
123aaca
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/feature-flagging #2885 +/- ##
============================================================
- Coverage 70.74% 70.26% -0.48%
============================================================
Files 810 827 +17
Lines 29666 30069 +403
Branches 5079 5122 +43
============================================================
+ Hits 20987 21127 +140
- Misses 7265 7497 +232
- Partials 1414 1445 +31
🚀 New features to boost your workflow:
|
typotter
approved these changes
Sep 18, 2025
typotter
left a comment
typotter
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for getting our CI to green
| ?.log( | ||
| InternalLogger.Level.WARN, | ||
| InternalLogger.Target.USER, | ||
| { NO_PROVIDER_REGISTERED_MESSAGE.format(Locale.US, sdkCore.name) } |
Contributor
There was a problem hiding this comment.
ooc, what what is the detekt rule that is against what looks like a pretty clean string build?
Member
Author
There was a problem hiding this comment.
UnsafeThirdPartyFunctionCall (format potentially throwing IllegalFormatException)
jonathanmos
marked this pull request as ready for review
September 18, 2025 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Please ignore this PR - it relates to the feature flags development.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)