Make AndroidMDrawableToColorMapper and AndroidQDrawableToColorMapper internal#2873
Merged
0xnm merged 1 commit intoSep 15, 2025
Merged
Conversation
ambushwork
previously approved these changes
Sep 12, 2025
0xnm
force-pushed
the
nogorodnikov/make-drawable-to-color-mappers-internal
branch
from
September 12, 2025 14:54
cf0bd92 to
24c820a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2873 +/- ##
===========================================
+ Coverage 70.49% 70.50% +0.01%
===========================================
Files 809 809
Lines 29482 29482
Branches 5054 5054
===========================================
+ Hits 20782 20786 +4
- Misses 7273 7276 +3
+ Partials 1427 1420 -7
🚀 New features to boost your workflow:
|
ambushwork
approved these changes
Sep 15, 2025
jonathanmos
approved these changes
Sep 15, 2025
0xnm
deleted the
nogorodnikov/make-drawable-to-color-mappers-internal
branch
September 15, 2025 07:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These two classes are not used outside of their module, so they can be
internal.Yes, it is a change in the public API, but these classes are not supposed to be used by the customers anyway.
Review checklist (to be filled by reviewers)