Skip to content

RUM-11638: Safe serialization of account.extraInfo#2862

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-11638/safe-serialize-of-account-extra-info
Sep 8, 2025
Merged

RUM-11638: Safe serialization of account.extraInfo#2862
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-11638/safe-serialize-of-account-extra-info

Conversation

@0xnm

@0xnm 0xnm commented Sep 8, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR adds safe serialization and sanitization of the account.extraInfo attributes provided by the user and also adds a missing test coverage.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm force-pushed the nogorodnikov/rum-11638/safe-serialize-of-account-extra-info branch from dd19935 to ffea0ef Compare September 8, 2025 11:16
@codecov-commenter

codecov-commenter commented Sep 8, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.85%. Comparing base (6e78b75) to head (ffea0ef).
⚠️ Report is 1505 commits behind head on develop.

Files with missing lines Patch % Lines
...trace/internal/domain/event/SpanEventSerializer.kt 95.83% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2862      +/-   ##
===========================================
- Coverage    70.91%   70.85%   -0.06%     
===========================================
  Files          809      809              
  Lines        29460    29482      +22     
  Branches      4937     4940       +3     
===========================================
- Hits         20889    20887       -2     
- Misses        7236     7238       +2     
- Partials      1335     1357      +22     
Files with missing lines Coverage Δ
...id/log/internal/domain/event/LogEventSerializer.kt 100.00% <100.00%> (ø)
...trace/internal/domain/event/SpanEventSerializer.kt 94.34% <95.83%> (+1.48%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm marked this pull request as ready for review September 8, 2025 12:00
@0xnm
0xnm requested review from a team as code owners September 8, 2025 12:00
@0xnm
0xnm merged commit acc2782 into develop Sep 8, 2025
25 checks passed
@0xnm
0xnm deleted the nogorodnikov/rum-11638/safe-serialize-of-account-extra-info branch September 8, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants