Skip to content

Use single source of truth for os and device properties definitions for Logs and Traces#2859

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/use-single-source-of-truth-for-os-device-definition
Sep 8, 2025
Merged

Use single source of truth for os and device properties definitions for Logs and Traces#2859
0xnm merged 1 commit into
developfrom
nogorodnikov/use-single-source-of-truth-for-os-device-definition

Conversation

@0xnm

@0xnm 0xnm commented Sep 5, 2025

Copy link
Copy Markdown
Member

What does this PR do?

By relying on the separate files definitions, although they are taken from the same source, they may have different revisions.

This PR instead points to the single location of the data model definition in RUM, guaranteeing the same model across RUM, Logs and Traces.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Comment thread features/dd-sdk-android-logs/build.gradle.kts
@0xnm
0xnm marked this pull request as ready for review September 5, 2025 16:10
@0xnm
0xnm requested review from a team as code owners September 5, 2025 16:10
@codecov-commenter

codecov-commenter commented Sep 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.84%. Comparing base (f351e48) to head (2bf53be).
⚠️ Report is 1528 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2859      +/-   ##
===========================================
+ Coverage    70.75%   70.84%   +0.09%     
===========================================
  Files          809      809              
  Lines        29460    29463       +3     
  Branches      4937     4937              
===========================================
+ Hits         20844    20873      +29     
+ Misses        7260     7254       -6     
+ Partials      1356     1336      -20     

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween
satween self-requested a review September 8, 2025 08:55
@0xnm
0xnm merged commit 6e78b75 into develop Sep 8, 2025
26 checks passed
@0xnm
0xnm deleted the nogorodnikov/use-single-source-of-truth-for-os-device-definition branch September 8, 2025 09:31
@ncreated
ncreated restored the nogorodnikov/use-single-source-of-truth-for-os-device-definition branch April 9, 2026 10:20
@0xnm
0xnm deleted the nogorodnikov/use-single-source-of-truth-for-os-device-definition branch April 24, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants