Fix RUM feature context in telemetry#2857
Merged
aleksandr-gringauz merged 1 commit intoSep 5, 2025
Merged
Conversation
maciejburda
previously approved these changes
Sep 5, 2025
satween
previously approved these changes
Sep 5, 2025
aleksandr-gringauz
dismissed stale reviews from satween and maciejburda
via
September 5, 2025 09:59
e49d1c4
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/add-rum-context-to-telemetry
branch
from
September 5, 2025 09:59
14005dc to
e49d1c4
Compare
0xnm
approved these changes
Sep 5, 2025
aleksandr-gringauz
marked this pull request as ready for review
September 5, 2025 11:05
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/add-rum-context-to-telemetry
branch
from
September 5, 2025 11:20
e49d1c4 to
9d6dada
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2857 +/- ##
===========================================
- Coverage 70.76% 70.75% -0.01%
===========================================
Files 809 809
Lines 29457 29460 +3
Branches 4937 4937
===========================================
- Hits 20844 20842 -2
- Misses 7261 7262 +1
- Partials 1352 1356 +4
🚀 New features to boost your workflow:
|
aleksandr-gringauz
deleted the
aleksandr-gringauz/add-rum-context-to-telemetry
branch
September 5, 2025 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before the context from the RUM feature wasn't included in the telemetry logs. But it should be, because we attach the data like
application_idandsession_idto the events here.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)