Skip to content

[RUM-11509][v3]: Raising minSdk version#2844

Merged
satween merged 3 commits into
developfrom
tvaleev/feature/RUM-11509-raising-min-sdk
Sep 3, 2025
Merged

[RUM-11509][v3]: Raising minSdk version#2844
satween merged 3 commits into
developfrom
tvaleev/feature/RUM-11509-raising-min-sdk

Conversation

@satween

@satween satween commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Increasing minSdk version to 23.
Updating metrics-performance lib version to 1.0.0-beta03

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween requested review from a team as code owners August 29, 2025 10:12
Comment thread buildSrc/src/main/kotlin/com/datadog/gradle/config/AndroidConfig.kt Outdated
Comment thread buildSrc/src/main/kotlin/com/datadog/gradle/config/AndroidConfig.kt
@satween
satween force-pushed the tvaleev/feature/RUM-11509-raising-min-sdk branch 3 times, most recently from b601c9c to ce2c5a6 Compare August 29, 2025 11:34
@codecov-commenter

codecov-commenter commented Aug 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 47.27273% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.70%. Comparing base (f5dbe0e) to head (aa7f9e0).
⚠️ Report is 1516 commits behind head on develop.

Files with missing lines Patch % Lines
...ssionreplay/utils/AndroidMDrawableToColorMapper.kt 48.84% 37 Missing and 7 partials ⚠️
...l/recorder/mapper/CheckableCompoundButtonMapper.kt 26.32% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2844      +/-   ##
===========================================
+ Coverage    70.70%   70.70%   +0.01%     
===========================================
  Files          810      809       -1     
  Lines        29477    29448      -29     
  Branches      4945     4937       -8     
===========================================
- Hits         20840    20821      -19     
+ Misses        7275     7266       -9     
+ Partials      1362     1361       -1     
Files with missing lines Coverage Δ
...domain/accessibility/DefaultAccessibilityReader.kt 98.86% <100.00%> (-0.03%) ⬇️
.../instrumentation/gestures/FixedWindowCallback.java 88.89% <ø> (ø)
...ssionreplay/internal/recorder/ViewUtilsInternal.kt 100.00% <100.00%> (+6.25%) ⬆️
...droid/sessionreplay/utils/DrawableToColorMapper.kt 50.00% <100.00%> (+16.67%) ⬆️
...l/recorder/mapper/CheckableCompoundButtonMapper.kt 50.00% <26.32%> (+11.54%) ⬆️
...ssionreplay/utils/AndroidMDrawableToColorMapper.kt 49.44% <48.84%> (-30.56%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

timeout: 1h
variables:
ANDROID_API: "21"
ANDROID_API: "23"

@aleksandr-gringauz aleksandr-gringauz Aug 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFYI

We also need to update here "platforms;android-21" "build-tools;21.0.0" "system-images;android-21;google_apis;arm64-v8a" that are pre-downloaded on the CI images (change 21 to 23).

But this is not a blocker to this pr, because our CI contains code that will install them.

0xnm
0xnm previously approved these changes Aug 29, 2025
@satween
satween dismissed stale reviews from 0xnm and aleksandr-gringauz via a1cc689 August 29, 2025 16:54
jonathanmos
jonathanmos previously approved these changes Sep 1, 2025
@satween
satween force-pushed the tvaleev/feature/RUM-11509-raising-min-sdk branch 2 times, most recently from 2bdb529 to 4a6d1aa Compare September 1, 2025 12:27
@satween
satween requested a review from 0xnm September 1, 2025 14:04
ambushwork
ambushwork previously approved these changes Sep 1, 2025
Comment thread instrumented/integration/build.gradle.kts Outdated
@satween satween closed this Sep 2, 2025
@satween satween reopened this Sep 3, 2025
@satween
satween changed the base branch from feature/v3 to develop September 3, 2025 11:19
@satween
satween force-pushed the tvaleev/feature/RUM-11509-raising-min-sdk branch from 65fbb67 to aa7f9e0 Compare September 3, 2025 11:29
@satween
satween merged commit 2da22e3 into develop Sep 3, 2025
25 checks passed
@satween
satween deleted the tvaleev/feature/RUM-11509-raising-min-sdk branch September 3, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants