[RUM-11290][FO]: Dropping events with blank operation name or key#2835
Merged
satween merged 1 commit intoAug 25, 2025
Merged
Conversation
3 tasks
0xnm
reviewed
Aug 25, 2025
satween
force-pushed
the
tvaleev/feature/RUM-11290-user-input-sanitization
branch
from
August 25, 2025 15:21
f794f59 to
6781d12
Compare
…erations arguments. Blank values will lead to dropping events
satween
force-pushed
the
tvaleev/feature/RUM-11290-user-input-sanitization
branch
from
August 25, 2025 15:21
6781d12 to
f616af3
Compare
0xnm
approved these changes
Aug 25, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/featureoperations #2835 +/- ##
=============================================================
- Coverage 70.10% 70.03% -0.07%
=============================================================
Files 835 835
Lines 31462 31475 +13
Branches 5279 5284 +5
=============================================================
- Hits 22056 22042 -14
- Misses 7926 7943 +17
- Partials 1480 1490 +10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds validation logic for the feature operation event with blank name or operationKey parameter
Motivation
Blank input should be dropped according to RFC as invalid - there is no sense to send event with blank
name/operationKey. Such parameters hard to filter on the platform and in most cases they indicates error in user input .Review checklist (to be filled by reviewers)