Skip to content

Remove generation of models from internal schemas for RUM#2834

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/remove-unused-models-generation
Aug 26, 2025
Merged

Remove generation of models from internal schemas for RUM#2834
0xnm merged 1 commit into
developfrom
nogorodnikov/remove-unused-models-generation

Conversation

@0xnm

@0xnm 0xnm commented Aug 25, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Add internal RUM schemas to the list of ignored files: they shouldn't have their own models, they are supposed to be included and be a part of host model.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners August 25, 2025 12:39
satween
satween previously approved these changes Aug 25, 2025
@0xnm
0xnm force-pushed the nogorodnikov/remove-unused-models-generation branch from 4a0d953 to c989f8b Compare August 25, 2025 12:57
@0xnm
0xnm requested a review from satween August 25, 2025 12:57
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.99%. Comparing base (207c199) to head (c989f8b).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2834      +/-   ##
===========================================
- Coverage    70.03%   69.99%   -0.04%     
===========================================
  Files          845      845              
  Lines        31497    31497              
  Branches      5283     5283              
===========================================
- Hits         22056    22044      -12     
- Misses        7962     7969       +7     
- Partials      1479     1484       +5     

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit a76bac2 into develop Aug 26, 2025
25 checks passed
@0xnm
0xnm deleted the nogorodnikov/remove-unused-models-generation branch August 26, 2025 07:24
@0xnm 0xnm mentioned this pull request Sep 3, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants