Skip to content

[RUM-11414][FO]: Replacing RumVitalEvent with VitalEvent#2831

Merged
satween merged 1 commit into
feature/featureoperationsfrom
tvaleev/feature/RUM-11414-eliminating-rum-prefix
Aug 21, 2025
Merged

[RUM-11414][FO]: Replacing RumVitalEvent with VitalEvent#2831
satween merged 1 commit into
feature/featureoperationsfrom
tvaleev/feature/RUM-11414-eliminating-rum-prefix

Conversation

@satween

@satween satween commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Removing Rum prefix from RumVitalEvent, aligning naming with other RUM events

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween requested review from a team as code owners August 21, 2025 10:55
@satween satween changed the title RUM-11414: Replacing RumVitalEvent with VitalEvent [RUM-11414][FO]: Replacing RumVitalEvent with VitalEvent Aug 21, 2025
@satween
satween force-pushed the tvaleev/feature/RUM-11414-eliminating-rum-prefix branch from 8ccd155 to d92b407 Compare August 21, 2025 10:58
@codecov-commenter

codecov-commenter commented Aug 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.87500% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.04%. Comparing base (fd55c46) to head (d92b407).
⚠️ Report is 395 commits behind head on feature/featureoperations.

Files with missing lines Patch % Lines
...g/android/rum/internal/domain/scope/RumEventExt.kt 45.45% 5 Missing and 1 partial ⚠️
.../android/rum/internal/domain/scope/RumViewScope.kt 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                      Coverage Diff                      @@
##           feature/featureoperations    #2831      +/-   ##
=============================================================
+ Coverage                      69.96%   70.04%   +0.07%     
=============================================================
  Files                            835      835              
  Lines                          31444    31444              
  Branches                        5277     5277              
=============================================================
+ Hits                           21999    22022      +23     
+ Misses                          7957     7934      -23     
  Partials                        1488     1488
Files with missing lines Coverage Δ
...kotlin/com/datadog/android/rum/RumConfiguration.kt 97.50% <ø> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.41% <100.00%> (-0.27%) ⬇️
.../datadog/android/rum/internal/RumSessionTypeExt.kt 100.00% <100.00%> (+11.11%) ⬆️
...ndroid/rum/internal/domain/event/RumEventMapper.kt 100.00% <100.00%> (ø)
...id/rum/internal/domain/event/RumEventSerializer.kt 84.15% <100.00%> (ø)
.../android/rum/internal/domain/scope/RumViewScope.kt 93.84% <80.00%> (ø)
...g/android/rum/internal/domain/scope/RumEventExt.kt 92.43% <45.45%> (+0.95%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween
satween merged commit 408586a into feature/featureoperations Aug 21, 2025
25 checks passed
@satween
satween deleted the tvaleev/feature/RUM-11414-eliminating-rum-prefix branch August 21, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@satween @codecov-commenter @0xnm