RUM-11386: Implement Navigation3 view tracking side effect#2830
Merged
Conversation
ambushwork
force-pushed
the
yl/nav3/api-implementation
branch
3 times, most recently
from
August 21, 2025 10:41
d9bcd17 to
bd81feb
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2830 +/- ##
===========================================
- Coverage 70.16% 70.02% -0.13%
===========================================
Files 843 845 +2
Lines 31423 31493 +70
Branches 5263 5283 +20
===========================================
+ Hits 22045 22052 +7
- Misses 7901 7963 +62
- Partials 1477 1478 +1
🚀 New features to boost your workflow:
|
ambushwork
force-pushed
the
yl/nav3/api-implementation
branch
2 times, most recently
from
August 21, 2025 12:27
76c63d1 to
767f3c4
Compare
ambushwork
marked this pull request as ready for review
August 21, 2025 12:34
| } | ||
|
|
||
| @Composable | ||
| @NonRestartableComposable |
Contributor
There was a problem hiding this comment.
I know it existed before in InternalNavigationViewTrackingStrategy, but curious. Why do we need this NonRestartableComposable thing?
Member
Author
There was a problem hiding this comment.
If I understand correctly it tells compiler that this function is stable, never needs to be recomposed independently, it's a recomposition optimisation
ambushwork
force-pushed
the
yl/nav3/api-implementation
branch
from
August 21, 2025 14:21
767f3c4 to
d64e40c
Compare
aleksandr-gringauz
approved these changes
Aug 21, 2025
| ?.enrichWithConstantAttribute(ViewScopeInstrumentationType.COMPOSE) | ||
| ?: emptyMap() | ||
|
|
||
| GlobalRumMonitor.get(sdkCore).startView( |
Contributor
Member
Author
There was a problem hiding this comment.
yes, you are totally right, actually that will be my next commit, sorry for not being clear here
aleksandr-gringauz
self-requested a review
August 22, 2025 07:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement Navigation3 view tracking side effect
Motivation
RUM-11386
Demo
Sample app with
Navigation3TrackingEffectsend correct view events when navigating.Review checklist (to be filled by reviewers)