Skip to content

Move OkHttp client initialization to background thread#2829

Merged
0xnm merged 3 commits into
developfrom
nogorodnikov/lazy-okhttp-client
Aug 21, 2025
Merged

Move OkHttp client initialization to background thread#2829
0xnm merged 3 commits into
developfrom
nogorodnikov/lazy-okhttp-client

Conversation

@0xnm

@0xnm 0xnm commented Aug 21, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This is a pull of contribution made by @Laimiux in #2824 into the repo directly from the fork to be able to run CI.

Check original PR for more details.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Aug 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.16%. Comparing base (e83db32) to head (ee3e622).
⚠️ Report is 354 commits behind head on develop.

Files with missing lines Patch % Lines
...n/com/datadog/android/core/internal/CoreFeature.kt 95.65% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2829      +/-   ##
===========================================
+ Coverage    70.13%   70.16%   +0.03%     
===========================================
  Files          843      843              
  Lines        31423    31427       +4     
  Branches      5263     5263              
===========================================
+ Hits         22037    22050      +13     
+ Misses        7906     7899       -7     
+ Partials      1480     1478       -2
Files with missing lines Coverage Δ
...in/com/datadog/android/core/internal/SdkFeature.kt 91.13% <100.00%> (ø)
...n/com/datadog/android/core/internal/CoreFeature.kt 87.28% <95.65%> (-0.14%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm marked this pull request as ready for review August 21, 2025 11:23
@0xnm
0xnm requested review from a team as code owners August 21, 2025 11:23
@0xnm 0xnm mentioned this pull request Aug 21, 2025
Closed
3 tasks
@0xnm
0xnm merged commit 0606a31 into develop Aug 21, 2025
25 checks passed
@0xnm
0xnm deleted the nogorodnikov/lazy-okhttp-client branch August 21, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambushwork ambushwork ambushwork approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @ambushwork @Laimiux