[RUM-11251][FO]: Fix RumVitalEvent serialization logic#2828
Merged
satween merged 2 commits intoAug 21, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/featureoperations #2828 +/- ##
=============================================================
+ Coverage 69.95% 70.12% +0.17%
=============================================================
Files 835 835
Lines 31418 31448 +30
Branches 5272 5277 +5
=============================================================
+ Hits 21978 22051 +73
+ Misses 7952 7932 -20
+ Partials 1488 1465 -23
🚀 New features to boost your workflow:
|
0xnm
reviewed
Aug 21, 2025
| fun setActionEventMapper(com.datadog.android.event.EventMapper<com.datadog.android.rum.model.ActionEvent>): Builder | ||
| fun setErrorEventMapper(com.datadog.android.event.EventMapper<com.datadog.android.rum.model.ErrorEvent>): Builder | ||
| fun setLongTaskEventMapper(com.datadog.android.event.EventMapper<com.datadog.android.rum.model.LongTaskEvent>): Builder | ||
| fun setVitalEventMapper(com.datadog.android.event.EventMapper<com.datadog.android.rum.model.RumVitalEvent>): Builder |
Member
There was a problem hiding this comment.
It should be called VitalEvent, because for other events Rum prefix is removed. Can you please do this change as a part of this PR?
Contributor
Author
There was a problem hiding this comment.
I will make it in the separate one because the amount of changes will be big enough
ambushwork
approved these changes
Aug 21, 2025
mariusc83
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It turned out that vital event wasn't sent to backend because there was no serialization logic added.
(back-end wasn't ready at the previous iterations, so it was hard to notice any issues)
I've added serialization same way it's done for other events like
LongTaskEvent,ViewEventetc.As (according to schema)
RumVitalEventalso containsusr,contextandaccountsanitization for those attributes was also added.I've also added support for
setVitalEventMapperand added custom mapper forsampleandbenchmarkingapps.Please let me know if some of those changes were unnecessary.
Review checklist (to be filled by reviewers)