Skip to content

RUM-11385: Create Nav3 demo screen in sample app#2825

Merged
ambushwork merged 1 commit into
developfrom
yl/nav3/sample-app
Aug 21, 2025
Merged

RUM-11385: Create Nav3 demo screen in sample app#2825
ambushwork merged 1 commit into
developfrom
yl/nav3/sample-app

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

Create Nav3 demo screen in sample app.

The screen use NavDisplay and navigates among 3 simple compose screen: "Home", "Discovery" and "Settings"

Motivation

RUM-11385

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/nav3/sample-app branch 2 times, most recently from fb46e30 to 6d6079c Compare August 20, 2025 09:25
@ambushwork
ambushwork marked this pull request as ready for review August 21, 2025 06:12
@ambushwork
ambushwork requested review from a team as code owners August 21, 2025 06:13
@codecov-commenter

codecov-commenter commented Aug 21, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.18%. Comparing base (1d4989e) to head (64c0a60).
⚠️ Report is 1855 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2825      +/-   ##
===========================================
+ Coverage    70.13%   70.18%   +0.05%     
===========================================
  Files          843      843              
  Lines        31423    31423              
  Branches      5263     5263              
===========================================
+ Hits         22037    22052      +15     
+ Misses        7906     7896      -10     
+ Partials      1480     1475       -5     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

0xnm
0xnm previously approved these changes Aug 21, 2025
0xnm
0xnm previously approved these changes Aug 21, 2025
Comment thread gradle/libs.versions.toml
@ambushwork
ambushwork changed the base branch from feature/navigation-3 to develop August 21, 2025 09:24
@ambushwork
ambushwork merged commit 170900c into develop Aug 21, 2025
24 of 25 checks passed
@ambushwork
ambushwork deleted the yl/nav3/sample-app branch August 21, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants