Some additional accessibility test coverage#2823
Merged
jonathanmos merged 2 commits intoAug 26, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2823 +/- ##
===========================================
- Coverage 70.03% 70.01% -0.01%
===========================================
Files 845 845
Lines 31497 31467 -30
Branches 5283 5286 +3
===========================================
- Hits 22056 22031 -25
+ Misses 7962 7957 -5
Partials 1479 1479
🚀 New features to boost your workflow:
|
jonathanmos
force-pushed
the
jmoskovich/additional-accessibilty-coverage
branch
from
August 19, 2025 11:57
c26989a to
aedbf98
Compare
jonathanmos
marked this pull request as ready for review
August 19, 2025 13:27
0xnm
reviewed
Aug 19, 2025
jonathanmos
force-pushed
the
jmoskovich/additional-accessibilty-coverage
branch
from
August 25, 2025 13:09
aedbf98 to
2b7e1eb
Compare
ambushwork
previously approved these changes
Aug 26, 2025
0xnm
reviewed
Aug 26, 2025
jonathanmos
force-pushed
the
jmoskovich/additional-accessibilty-coverage
branch
from
August 26, 2025 08:50
2b7e1eb to
aa79b82
Compare
0xnm
approved these changes
Aug 26, 2025
ambushwork
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor
DefaultAccessibilitySnapshotManagerto return a nullable object - this simplifies the later logic in terms of knowing if anything changed in the accessibility state.Adds some additional test coverage for accessibility around the logic for view reduction
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)