[RUM-11289][FO]: supporting user debug logs#2819
Merged
Merged
Conversation
satween
changed the title
satween
changed the title
0xnm
previously approved these changes
Aug 13, 2025
| reportTelemetry { FO_TELEMETRY_FAILED_MESSAGE } | ||
| } | ||
|
|
||
| private fun logToUser(messageProvider: () -> String) { |
Member
There was a problem hiding this comment.
very minor nit:
Suggested change
| private fun logToUser(messageProvider: () -> String) { | |
| private fun logDebugToUser(messageProvider: () -> String) { |
Contributor
Author
There was a problem hiding this comment.
Bit refactored to use for whole class. The method accepts log level now
| eventTime = getEventTime(attributes) | ||
| ) | ||
| ) | ||
| logToUser { "Feature Operation `$name` (operationKey `$operationKey`) was started." } |
Member
There was a problem hiding this comment.
I'm not the native speaker, but I would suggest to remove was here and below. Like operation started, operation successfully ended.
It is quite common to use such simpler form in log messages.
pinging @fuzzybinary / @awforsythe for the input
Member
There was a problem hiding this comment.
I agree, I can update on the iOS side
satween
force-pushed
the
tvaleev/feature/RUM-11289
branch
from
August 14, 2025 12:04
e7803bf to
49f23a5
Compare
satween
changed the base branch from
tvaleev/feature/RUM-11253
to
feature/featureoperations
August 14, 2025 12:05
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/featureoperations #2819 +/- ##
=============================================================
+ Coverage 69.99% 70.11% +0.12%
=============================================================
Files 835 835
Lines 31412 31418 +6
Branches 5272 5272
=============================================================
+ Hits 21985 22027 +42
+ Misses 7928 7916 -12
+ Partials 1499 1475 -24
🚀 New features to boost your workflow:
|
0xnm
approved these changes
Aug 14, 2025
satween
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports debug logs for FO methods.
Motivation
Logs aimed to help customers check the correctness of integration.
Review checklist (to be filled by reviewers)