[RUM-11253][FO]: Adding telemetry for basic methods#2818
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/featureoperations #2818 +/- ##
=============================================================
+ Coverage 70.00% 70.06% +0.06%
=============================================================
Files 835 835
Lines 31444 31462 +18
Branches 5277 5279 +2
=============================================================
+ Hits 22012 22042 +30
+ Misses 7938 7932 -6
+ Partials 1494 1488 -6
🚀 New features to boost your workflow:
|
ambushwork
reviewed
Aug 13, 2025
satween
force-pushed
the
tvaleev/feature/RUM-11253
branch
from
August 13, 2025 13:51
6a75d81 to
1fc34ea
Compare
satween
changed the title
satween
force-pushed
the
tvaleev/feature/RUM-11253
branch
from
August 25, 2025 12:52
1fc34ea to
3220078
Compare
ambushwork
approved these changes
Aug 25, 2025
| forge: Forge | ||
| ) { | ||
| // Given | ||
| val mockInternalLogger = mock<InternalLogger>() |
Member
There was a problem hiding this comment.
very minor, this can be mock as a local variable and reused in every test case
| InternalTelemetryEvent.ApiUsage.AddOperationStepVital.ActionType.SUCCEED | ||
| ), | ||
| samplingRate = 15f | ||
| ) |
Member
There was a problem hiding this comment.
minor: nice to verify no more interactions of logApiUsage
Contributor
Author
|
Going to address tests notes in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds telemetry logs for feature operations methods
Review checklist (to be filled by reviewers)