[RUM-11252][FO]: DTO schema integration#2816
Merged
Merged
Conversation
satween
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/featureoperations #2816 +/- ##
=============================================================
+ Coverage 69.91% 69.93% +0.02%
=============================================================
Files 835 835
Lines 31303 31412 +109
Branches 5259 5272 +13
=============================================================
+ Hits 21885 21966 +81
- Misses 7929 7959 +30
+ Partials 1489 1487 -2
🚀 New features to boost your workflow:
|
aleksandr-gringauz
approved these changes
Aug 12, 2025
jonathanmos
approved these changes
Aug 12, 2025
| FailureReason.OTHER -> RumVitalEvent.FailureReason.OTHER | ||
| } | ||
| } | ||
| // |
Member
There was a problem hiding this comment.
nit: shouldn't this be endregion?
Contributor
Author
There was a problem hiding this comment.
will fix in the following PR's
0xnm
reviewed
Aug 13, 2025
Comment on lines
+241
to
+266
| private fun onStartFeatureOperation(event: RumRawEvent.StartFeatureOperation, writer: DataWriter<Any>) { | ||
| sdkCore.newRumEventWriteOperation(writer) { datadogContext -> | ||
| newVitalEvent( | ||
| datadogContext, | ||
| name = event.name, | ||
| operationKey = event.operationKey, | ||
| stepType = RumVitalEvent.StepType.START, | ||
| failureReason = null, | ||
| attributes = event.attributes | ||
| ) | ||
| }.submit() | ||
| sendViewUpdate(event, writer) | ||
| } | ||
|
|
||
| private fun onStopFeatureOperation(event: RumRawEvent.StopFeatureOperation, writer: DataWriter<Any>) { | ||
| sdkCore.newRumEventWriteOperation(writer) { datadogContext -> | ||
| newVitalEvent( | ||
| datadogContext, | ||
| name = event.name, | ||
| operationKey = event.operationKey, | ||
| stepType = RumVitalEvent.StepType.END, | ||
| failureReason = event.failureReason?.toSchemaFailureReason(), | ||
| attributes = event.attributes | ||
| ) | ||
| }.submit() | ||
| sendViewUpdate(event, writer) |
Member
There was a problem hiding this comment.
why do we need to send view update if creating/sending vital event doesn't change any state (at least of RumViewScope; it is clear that it might change the state of upstream scopes)?
do we risk exploding the number of view updates?
satween
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
vital-schema.jsonMotivation
See RFC in ticket description
Additional Notes
Note that it's not complete P0 implementation.
Debugging logs support, telemetry and name sanitization will be added later.
Review checklist (to be filled by reviewers)