RUM-11120: Add battery and display attributes#2815
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-11120/battery-attributes
branch
from
August 10, 2025 15:10
77d3e69 to
aa393a5
Compare
Codecov Report❌ Patch coverage is Please upload reports for the commit c0de10f to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## develop #2815 +/- ##
===========================================
- Coverage 70.18% 70.09% -0.09%
===========================================
Files 834 843 +9
Lines 31296 31442 +146
Branches 5259 5261 +2
===========================================
+ Hits 21964 22037 +73
- Misses 7883 7922 +39
- Partials 1449 1483 +34
🚀 New features to boost your workflow:
|
jonathanmos
force-pushed
the
jmoskovich/rum-11120/battery-attributes
branch
from
August 12, 2025 11:49
39b52d4 to
9f737d7
Compare
jonathanmos
marked this pull request as ready for review
August 12, 2025 13:02
satween
reviewed
Aug 13, 2025
satween
reviewed
Aug 13, 2025
jonathanmos
commented
Aug 13, 2025
aleksandr-gringauz
previously approved these changes
Aug 14, 2025
aleksandr-gringauz
approved these changes
Aug 18, 2025
satween
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds some battery and display attributes to view updates. The following fields were added:
battery_level: The current battery charge level, expressed as a float from 0.0 (empty) to 1.0 (full). This is to align with ios, so we lose some granularity as android can measure to within 1% of the battery level while ios shows only to the nearest 10%. Monitored by polling once every 60 seconds - it didn't seem a good idea to register a listener as the listener was firing sometimes multiple times per second.low_power_mode: A boolean indicating whether the device is currently in Low Power Mode. Monitored with a broadcast receiver.brightness_level: The current screen brightness, normalized as a float between 0.0 (darkest) and 1.0 (brightest). Monitored with a content observer.Motivation
Part of adding metadata fields.
Additional Notes
Refactor of the architecture of the info providers since we now have three providers (accessibility/battery/display) - all classes now implement the InfoProvider interface and use the same generic NoOp class. The generic interface returns a kv map and we use the concrete data classes to convert between the objects and this representation.
Review checklist (to be filled by reviewers)