[RUM-11249][FO]: public API#2814
Merged
Merged
Conversation
satween
marked this pull request as ready for review
August 8, 2025 13:51
aleksandr-gringauz
previously approved these changes
Aug 11, 2025
ambushwork
reviewed
Aug 11, 2025
satween
force-pushed
the
tvaleev/feature/RUM-11249
branch
from
August 11, 2025 12:18
13743b4 to
462502c
Compare
ambushwork
previously approved these changes
Aug 11, 2025
mariedm
reviewed
Aug 11, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/featureoperations #2814 +/- ##
=============================================================
- Coverage 70.18% 69.91% -0.27%
=============================================================
Files 834 835 +1
Lines 31296 31303 +7
Branches 5259 5259
=============================================================
- Hits 21964 21885 -79
- Misses 7883 7929 +46
- Partials 1449 1489 +40
🚀 New features to boost your workflow:
|
mariedm
requested changes
Aug 11, 2025
mariedm
left a comment
mariedm
left a comment
Member
There was a problem hiding this comment.
LGMT, but we must only expose 3 APIs: start, end successfully, and with failure.
satween
force-pushed
the
tvaleev/feature/RUM-11249
branch
from
August 11, 2025 14:56
462502c to
eaca227
Compare
mariedm
approved these changes
Aug 11, 2025
satween
changed the title
0xnm
reviewed
Aug 13, 2025
| fun failFeatureOperation( | ||
| name: String, | ||
| operationKey: String? = null, | ||
| failureReason: FailureReason, |
Member
There was a problem hiding this comment.
FYI: on iOS this attribute is called just reason, not failureReason, so it will be nice to align
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds public API without any implementation for the FO feature.
Motivation
This changes should unblock RN integration implementation
Review checklist (to be filled by reviewers)