RUM-11137: Move session properties to ddtags over query parameters#2812
Merged
aleksandr-gringauz merged 1 commit intoAug 6, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2812 +/- ##
===========================================
+ Coverage 69.91% 69.92% +0.02%
===========================================
Files 833 834 +1
Lines 31218 31225 +7
Branches 5242 5243 +1
===========================================
+ Hits 21823 21833 +10
- Misses 7912 7917 +5
+ Partials 1483 1475 -8
🚀 New features to boost your workflow:
|
aleksandr-gringauz
marked this pull request as ready for review
August 5, 2025 14:11
ambushwork
approved these changes
Aug 5, 2025
jonathanmos
approved these changes
Aug 6, 2025
aleksandr-gringauz
deleted the
aleksandr-gringauz/RUM-11137/props-to-ddtags
branch
August 6, 2025 08:07
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stop sending
service,version,sdk_version,envandvariantas HTTP query parameters to the RUM intake. Now sending them in each RUM event in a specialddtagsfield.It is a solution to the problem that if we obtain these parameters at the time of uploading to RUM intake from the current
DatadogContextthey actually might not correspond to the RUM events we are sending (for example after an app update). See the tickets for a more detailed description.I also removed some duplicate test forge factories from unit tests of
features:dd-sdk-android-webviewandsingle-fit:rum. Now we reuse the factories from thetestFixturesfolder offeatures:dd-sdk-android-rumproject. This is the main reason why this PR has so many removed lines of code.Here is a link to rum session with these changes.
envis visible in all RUM events. You can filter byvariant = us1andsdk_versionand see this session (so looks like the backend successfully understands theseddtags).Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)