RUM-10958: Fix WindowCallbackWrapper NPE#2800
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2800 +/- ##
===========================================
- Coverage 69.90% 69.88% -0.03%
===========================================
Files 831 832 +1
Lines 31138 31165 +27
Branches 5234 5234
===========================================
+ Hits 21766 21777 +11
- Misses 7896 7922 +26
+ Partials 1476 1466 -10
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
July 28, 2025 08:01
aleksandr-gringauz
approved these changes
Jul 28, 2025
3 tasks
nguyexua
added a commit
that referenced
this pull request
Mar 9, 2026
Extend FixedWindowCallback instead of using try-catch overrides, matching the pattern established in PR #2800. Add compileOnly dependency on dd-sdk-android-rum to access FixedWindowCallback.
nguyexua
added a commit
that referenced
this pull request
Mar 9, 2026
Extend FixedWindowCallback instead of using try-catch overrides, matching the pattern established in PR #2800. Add compileOnly dependency on dd-sdk-android-rum to access FixedWindowCallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Due to a system issue: https://issuetracker.google.com/issues/188568911
A null
menuargument can be passed into a@NonNulljava function ofWindow.Callback,and since our
WindowCallbackWrapperdelegates from this interface, kotlin function will check nullability then causes the crash.The fix is to tweak the
@NonNulldeclaration to@Nullableto get away with Kotlin nullable check.Motivation
RUM-10958
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)