Fix release checking script#2799
Merged
aleksandr-gringauz merged 1 commit intoJul 28, 2025
Merged
Conversation
aleksandr-gringauz
marked this pull request as ready for review
July 25, 2025 12:28
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2799 +/- ##
===========================================
+ Coverage 69.90% 69.92% +0.02%
===========================================
Files 831 831
Lines 31138 31138
Branches 5234 5234
===========================================
+ Hits 21766 21772 +6
Misses 7896 7896
+ Partials 1476 1470 -6 🚀 New features to boost your workflow:
|
ambushwork
approved these changes
Jul 28, 2025
aleksandr-gringauz
deleted the
aleksandr-gringauz/fix-release-checking-script
branch
July 28, 2025 08:08
mariusc83
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed that I removed
exit 1here by mistake.In case release artifact doesn't exist we must fail the script, so that the failure is reported to slack.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)