RUM-9631: Add accessibility attributes#2787
Merged
jonathanmos merged 4 commits intoJul 22, 2025
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-9631/accessibility-attributes
branch
from
July 15, 2025 08:24
30ee1a2 to
c065b0a
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-9631/accessibility-attributes
branch
from
July 16, 2025 09:03
ba54536 to
2232142
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2787 +/- ##
===========================================
+ Coverage 69.84% 69.90% +0.07%
===========================================
Files 826 831 +5
Lines 30953 31138 +185
Branches 5213 5234 +21
===========================================
+ Hits 21617 21767 +150
- Misses 7863 7901 +38
+ Partials 1473 1470 -3
🚀 New features to boost your workflow:
|
jonathanmos
marked this pull request as ready for review
July 16, 2025 10:18
ambushwork
reviewed
Jul 16, 2025
jonathanmos
force-pushed
the
jmoskovich/rum-9631/accessibility-attributes
branch
from
July 17, 2025 11:44
4c450ec to
bb1ce7c
Compare
ambushwork
approved these changes
Jul 21, 2025
aleksandr-gringauz
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets up a feature flag (
collectAccessibilitySettings). When this flag is active, the SDK collects a number of custom accessibility attributes to send in view updates under the "accessibility" tag. These attributes are:closed_captions_enabled (boolean) - has closed captioning been activated
color_inversion_enabled (boolean) - has color inversion been activated
reduced_animations_enabled (boolean) - has reduced animation been activated
screen_reader_enabled (boolean) - has talkback been activated
single_app_mode_enabled (boolean) - has screen pinning been activated
text_size (float) - current font size (1.0 is "normal" font)
Some attribute values are collected with listeners that record the new value whenever it changes. For attributes where this is not possible because no listener exists, the value is polled - but not more than once every 30 seconds.
Motivation
Collect additional user insights.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)