[RUM-10719]: Removing opentracing dependencies #2783
Merged
satween merged 15 commits intoJul 8, 2025
Merged
Conversation
satween
commented
Jul 7, 2025
| .withServiceName(serviceName) | ||
| .build() | ||
|
|
||
| datadogTracer.addScopeListener(object : DataScopeListener { |
Contributor
Author
There was a problem hiding this comment.
Replaced with standalone DataTracePropagationScopeListener class
satween
commented
Jul 7, 2025
| */ | ||
| fun setPartialFlushThreshold(threshold: Int): Builder { | ||
| builderDelegate.withPartialFlushThreshold(threshold) | ||
| builderDelegate.withPartialFlushMinSpans(threshold) |
Contributor
Author
There was a problem hiding this comment.
I realized that withPartialFlushThreshold and withPartialFlushMinSpans actually makes the same (otel and opentracing notation)
satween
commented
Jul 7, 2025
| } | ||
| } | ||
|
|
||
| private fun resolveSpanBuilderDecorator(): (SpanBuilder) -> SpanBuilder { |
Contributor
Author
There was a problem hiding this comment.
Moved inside DatadogTracerBuilderAdapter
aleksandr-gringauz
approved these changes
Jul 7, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## tvaleev/feature/RUM-9902-removing-unused-code #2783 +/- ##
=================================================================================
+ Coverage 67.41% 69.89% +2.49%
=================================================================================
Files 833 788 -45
Lines 30816 28746 -2070
Branches 5194 4823 -371
=================================================================================
- Hits 20772 20092 -680
+ Misses 8633 7324 -1309
+ Partials 1411 1330 -81
🚀 New features to boost your workflow:
|
satween
merged commit Jul 8, 2025
3ac2619
into
tvaleev/feature/RUM-9902-removing-unused-code
24 checks passed
0xnm
reviewed
Jul 8, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
io.opentracingdependencies from the project.io.opentracingclasseslegacypackage from the-trace-internalmoduleReview checklist (to be filled by reviewers)