Run unit tests from samples folder and for tools:benchmark module#2777
Merged
aleksandr-gringauz merged 1 commit intoJul 4, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2777 +/- ##
===========================================
- Coverage 69.84% 69.81% -0.03%
===========================================
Files 824 824
Lines 30881 30881
Branches 5195 5195
===========================================
- Hits 21566 21558 -8
- Misses 7850 7855 +5
- Partials 1465 1468 +3 🚀 New features to boost your workflow:
|
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/run-unit-tests-samples-and-benchmark
branch
from
July 4, 2025 10:58
d826667 to
032fe59
Compare
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/run-unit-tests-samples-and-benchmark
branch
from
July 4, 2025 11:02
032fe59 to
272000c
Compare
| firstValue.body, | ||
| fakeSpanJson, | ||
| contentType | ||
| contentTypePlainText |
| // Set a Longer | ||
| Thread.sleep(memoryUpdateIntervalMs) | ||
| fakeFile.writeText(generateStatusContent(vmRss)) | ||
| Thread.sleep(memoryUpdateIntervalMs) |
Contributor
Author
There was a problem hiding this comment.
testReader periodically reads data from a file link
we should sleep after we write to the file, not before, so that enough time passes for testReader to read the last value
aleksandr-gringauz
marked this pull request as ready for review
July 4, 2025 11:16
0xnm
approved these changes
Jul 4, 2025
aleksandr-gringauz
deleted the
aleksandr-gringauz/run-unit-tests-samples-and-benchmark
branch
July 4, 2025 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are tests in
tools:benchmarkandsample:benchmarkthat are not running on CI. I noticed that when I ran./gradlew testDebugUnitTestlocally and it failed onDatadogHttpClientTest.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)