RUM-10672: Stop telemetry for compose checkbox and radiobutton#2775
Merged
jonathanmos merged 1 commit intoJul 3, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2775 +/- ##
===========================================
- Coverage 70.03% 69.83% -0.20%
===========================================
Files 824 824
Lines 30877 30877
Branches 5196 5196
===========================================
- Hits 21623 21562 -61
- Misses 7818 7858 +40
- Partials 1436 1457 +21
🚀 New features to boost your workflow:
|
jonathanmos
marked this pull request as ready for review
July 3, 2025 11:10
0xnm
approved these changes
Jul 3, 2025
ambushwork
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The reflection by which we get attributes for radiobuttons and checkboxes in Compose is fragile and generates a lot of telemetry. Until we can find an alternative method to get the attributes, this PR removes the telemetry for these components.
Motivation
Volume of telemetry generated.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)