Skip to content

RUM-10621 Add clear user info API#2768

Merged
maciejburda merged 9 commits into
developfrom
maciey/RUM-10621/clear-user-info
Jul 3, 2025
Merged

RUM-10621 Add clear user info API#2768
maciejburda merged 9 commits into
developfrom
maciey/RUM-10621/clear-user-info

Conversation

@maciejburda

@maciejburda maciejburda commented Jun 30, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Adds API that allows clearing entire user object for the session.
It's needed because manual clearing user become impossible after this change: #2509

Motivation

It serves a purpose for some actual use cases. Related discussion can be found here: DataDog/dd-sdk-ios#2195

Additional Notes

Similar change on iOS: DataDog/dd-sdk-ios#2369

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@maciejburda
maciejburda requested review from a team as code owners June 30, 2025 11:18
0xnm
0xnm previously approved these changes Jun 30, 2025
jonathanmos
jonathanmos previously approved these changes Jun 30, 2025
Comment thread dd-sdk-android-core/src/main/kotlin/com/datadog/android/Datadog.kt Outdated
Comment thread dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/SdkCore.kt Outdated
ambushwork
ambushwork previously approved these changes Jul 1, 2025
@maciejburda
maciejburda dismissed stale reviews from ambushwork, jonathanmos, and 0xnm via 9dfb846 July 1, 2025 09:32
@codecov-commenter

codecov-commenter commented Jul 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.85%. Comparing base (2e51912) to head (4203b5c).
⚠️ Report is 1928 commits behind head on develop.

Files with missing lines Patch % Lines
...ore/src/main/kotlin/com/datadog/android/Datadog.kt 50.00% 1 Missing ⚠️
...tadog/android/core/internal/NoOpInternalSdkCore.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2768      +/-   ##
===========================================
- Coverage    70.03%   69.85%   -0.18%     
===========================================
  Files          824      824              
  Lines        30877    30881       +4     
  Branches      5196     5195       -1     
===========================================
- Hits         21623    21570      -53     
- Misses        7818     7845      +27     
- Partials      1436     1466      +30     
Files with missing lines Coverage Δ
...src/main/kotlin/com/datadog/android/api/SdkCore.kt 14.29% <ø> (ø)
...n/com/datadog/android/core/internal/DatadogCore.kt 82.14% <100.00%> (+0.08%) ⬆️
...roid/core/internal/user/DatadogUserInfoProvider.kt 100.00% <100.00%> (ø)
...ore/src/main/kotlin/com/datadog/android/Datadog.kt 68.37% <50.00%> (-0.70%) ⬇️
...tadog/android/core/internal/NoOpInternalSdkCore.kt 8.43% <0.00%> (-0.10%) ⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maciejburda
maciejburda merged commit 0249aa8 into develop Jul 3, 2025
25 checks passed
@maciejburda
maciejburda deleted the maciey/RUM-10621/clear-user-info branch July 3, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants