RUM-10143: Stop posting recorded data item from main thread#2763
Merged
Conversation
ambushwork
force-pushed
the
yl/remove-main-thread-post
branch
from
June 25, 2025 11:32
3040819 to
b7167aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2763 +/- ##
===========================================
+ Coverage 69.78% 69.88% +0.10%
===========================================
Files 824 824
Lines 30878 30877 -1
Branches 5196 5196
===========================================
+ Hits 21546 21577 +31
+ Misses 7852 7835 -17
+ Partials 1480 1465 -15
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
June 25, 2025 14:42
0xnm
approved these changes
Jun 25, 2025
jonathanmos
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It turns out we are posting the task from main thread for nothing, and it causes item dropped if the client's UI thread is busy, see in the ticket RUM-10143.
Motivation
RUM-10143
Review checklist (to be filled by reviewers)