RUM-10489: Make attributes argument optional in the event-related methods of RUM monitor#2760
Merged
0xnm merged 1 commit intoJun 25, 2025
Conversation
…hods of RUM monitor
0xnm
force-pushed
the
nogorodnikov/rum-10489/make-attributes-arg-optional-in-rummonitor
branch
from
June 24, 2025 17:05
0003743 to
ee8a6ec
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/v3 #2760 +/- ##
==============================================
+ Coverage 67.53% 67.58% +0.05%
==============================================
Files 818 818
Lines 30638 30642 +4
Branches 5179 5179
==============================================
+ Hits 20691 20709 +18
+ Misses 8551 8543 -8
+ Partials 1396 1390 -6
🚀 New features to boost your workflow:
|
ambushwork
previously approved these changes
Jun 25, 2025
ambushwork
left a comment
ambushwork
left a comment
Member
There was a problem hiding this comment.
LGTM, just curious why don't target this branch to develop?
Member
Author
|
It is possible to target |
Member
|
so it should target to |
Member
Author
|
It will, once underlying PR is merged. It is just a stacked PR. |
mariusc83
previously approved these changes
Jun 25, 2025
Base automatically changed from
nogorodnikov/remove-default-value-for-addAccountExtraInfo-call
to
feature/v3
June 25, 2025 09:30
0xnm
dismissed stale reviews from mariusc83 and ambushwork
June 25, 2025 09:30
The base branch was changed.
ambushwork
approved these changes
Jun 25, 2025
0xnm
deleted the
nogorodnikov/rum-10489/make-attributes-arg-optional-in-rummonitor
branch
June 25, 2025 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If we compare RUM monitor-related methods in iOS SDK with ones in Android SDK, we will see that Android SDK has inconsistency: some event-related methods have
attributesas optional argument, some don’t.We need to align with iOS SDK and make
attributesargument for such methods optional.This PR also removes redundant
emptyMapargument value at the call sites, but keeps it at theverifycalls.Review checklist (to be filled by reviewers)