Remove default value for the addAccountExtraInfo call#2759
Merged
0xnm merged 1 commit intoJun 25, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/v3 #2759 +/- ##
===========================================
Coverage 67.53% 67.53%
===========================================
Files 818 818
Lines 30640 30638 -2
Branches 5179 5179
===========================================
Hits 20691 20691
- Misses 8545 8551 +6
+ Partials 1404 1396 -8
🚀 New features to boost your workflow:
|
ambushwork
approved these changes
Jun 25, 2025
ambushwork
approved these changes
Jun 25, 2025
mariusc83
approved these changes
Jun 25, 2025
0xnm
deleted the
nogorodnikov/remove-default-value-for-addAccountExtraInfo-call
branch
June 25, 2025 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes default value for the
addAccountExtraInfocall, because this method is not supposed to be called with explicit arguments. This change also aligns with iOS SDK API.In addition, docs for the
account-related APIs are updated.@satween This is not a breaking change, because I don't think there is a use-case to call
addAccountExtraInfowithout arguments, but still it is better to note it for the migration doc.Review checklist (to be filled by reviewers)