Skip to content

Remove workaround when checking dd-sdk-android-benchmark-internal is published#2758

Merged
aleksandr-gringauz merged 1 commit into
developfrom
aleksandr-gringauz/remove-benchmark-internal-publishing-check-workaround
Jun 24, 2025
Merged

Remove workaround when checking dd-sdk-android-benchmark-internal is published#2758
aleksandr-gringauz merged 1 commit into
developfrom
aleksandr-gringauz/remove-benchmark-internal-publishing-check-workaround

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Not needed anymore because starting from 2.23.0 release we publish the benchmark module with new artifactId (dd-sdk-android-benchmark-internal).

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@aleksandr-gringauz
aleksandr-gringauz marked this pull request as ready for review June 24, 2025 12:13
@aleksandr-gringauz
aleksandr-gringauz requested review from a team as code owners June 24, 2025 12:13
@codecov-commenter

codecov-commenter commented Jun 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.87%. Comparing base (1de5d19) to head (f9363aa).
⚠️ Report is 1952 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2758      +/-   ##
===========================================
+ Coverage    69.78%   69.87%   +0.10%     
===========================================
  Files          824      824              
  Lines        30878    30878              
  Branches      5196     5196              
===========================================
+ Hits         21546    21576      +30     
+ Misses        7852     7839      -13     
+ Partials      1480     1463      -17     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz
aleksandr-gringauz merged commit b871d2a into develop Jun 24, 2025
26 checks passed
@aleksandr-gringauz
aleksandr-gringauz deleted the aleksandr-gringauz/remove-benchmark-internal-publishing-check-workaround branch June 24, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants