RUM-10409: fix effective sample rate calculation for SessionEndedMetricDispatcher#2744
Merged
Conversation
mariusc83
previously approved these changes
Jun 19, 2025
mariusc83
reviewed
Jun 19, 2025
| verify(mockInternalLogger).logMetric( | ||
| any(), | ||
| any(), | ||
| eq(15.0f), |
Member
There was a problem hiding this comment.
why is this 15.0f here ? shouldn't be the one provided in constructor ?
Contributor
Author
There was a problem hiding this comment.
the value, provided in constructor – is the session sampling rate, that will or will not start entire metric
15.0 - is the metric sampling rate, that determine wil or will not the whole metric will be sent.
So effective sampling rate = sessionSamplingRate * 15%
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2744 +/- ##
===========================================
- Coverage 69.77% 69.72% -0.04%
===========================================
Files 824 824
Lines 30790 30795 +5
Branches 5177 5177
===========================================
- Hits 21481 21471 -10
- Misses 7844 7859 +15
Partials 1465 1465
🚀 New features to boost your workflow:
|
0xnm
reviewed
Jun 19, 2025
satween
force-pushed
the
tvaleev/feature/RUM-10409
branch
from
June 19, 2025 14:57
e8948c8 to
26a89dc
Compare
0xnm
previously approved these changes
Jun 19, 2025
satween
force-pushed
the
tvaleev/feature/RUM-10409
branch
from
June 19, 2025 15:37
26a89dc to
04c405c
Compare
0xnm
approved these changes
Jun 19, 2025
mariusc83
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes wrong effective sampling rate value computation for SessionEndedMetricDispatcher.
Before this fix, sessionSampling rate was not take into a count for effective sampling rate of such events
Review checklist (to be filled by reviewers)