RUM-10422: Handle the case when DatadogContext is requested when SDK is getting deinitialized#2740
Merged
Conversation
…is getting deinitialized
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nogorodnikov/rum-8170/feature-context-sync #2740 +/- ##
===========================================================================
Coverage 69.82% 69.82%
===========================================================================
Files 824 824
Lines 30933 30934 +1
Branches 5188 5191 +3
===========================================================================
+ Hits 21597 21598 +1
+ Misses 7875 7864 -11
- Partials 1461 1472 +11
🚀 New features to boost your workflow:
|
mariusc83
approved these changes
Jun 19, 2025
0xnm
merged commit Jun 20, 2025
6375758
into
nogorodnikov/rum-8170/feature-context-sync
24 checks passed
0xnm
deleted the
nogorodnikov/rum-10422/handle-case-of-sdk-deinit-when-context-requested
branch
June 20, 2025 07:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is an edge case when calling
withWriteContext/withContext/... if we are in the process of SDK deinitialization.When starting the task submitted to the context processing queue we would like to check if
CoreFeatureis still alive.Normally, in the
CoreFeature.stopwe are callingshutdownNowfor the executors which interrupts the threads, but just in case if the stop approach is different in the future we just put one more check.Review checklist (to be filled by reviewers)